-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix#2094] Fix handling of balances when user has no tokens. #2095
Merged
DidierRLopes
merged 11 commits into
OpenBB-finance:main
from
jfarid27:bugfix/handling-no-token-crypto-balance
Jul 17, 2022
Merged
[Bugfix#2094] Fix handling of balances when user has no tokens. #2095
DidierRLopes
merged 11 commits into
OpenBB-finance:main
from
jfarid27:bugfix/handling-no-token-crypto-balance
Jul 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jfarid27 thanks for this! Can you do
to fix the tests please? |
Thank you @DidierRLopes. I pushed up some updates after figuring out how to run this. Please recheck! |
DidierRLopes
approved these changes
Jul 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Tested and it works 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds handling of user data when there is no tokens but ETH in the account.
Fixes #2094
Before
After
Motivation
Attempted to check an address of mine that only has ETH. Because of the token empty default line, it fails a number conversion in decimals and breaks.
Dependencies
None
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.