M1 macos build system #2504
Merged
M1 macos build system #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes codesigning tho
I am expecting a code sign error instead of a running the actual executable error. trying with -e prediction instead of -e prediction-m1-mac
piiq
approved these changes
Sep 6, 2022
simmonsj330
added a commit
that referenced
this pull request
Sep 7, 2022
* Create m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * taking out notarize and staple includes codesigning tho * changing prediction install I am expecting a code sign error instead of a running the actual executable error. trying with -e prediction instead of -e prediction-m1-mac * Changing prediction, keeping code signing * Update m1_macos_build.yml * Update m1_macos_build.yml * taking out integration tests * rerun * Update m1_macos_build.yml * adding pred back to turn to false * making same as upstream release * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com> Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
simmonsj330
added a commit
that referenced
this pull request
Sep 9, 2022
* Update pyproject.toml * Update setup.nsi * Update feature_flags.py * M1 macos build system (#2504) (#2514) * Create m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml * taking out notarize and staple includes codesigning tho * changing prediction install I am expecting a code sign error instead of a running the actual executable error. trying with -e prediction instead of -e prediction-m1-mac * Changing prediction, keeping code signing * Update m1_macos_build.yml * Update m1_macos_build.yml * taking out integration tests * rerun * Update m1_macos_build.yml * adding pred back to turn to false * making same as upstream release * Update m1_macos_build.yml * Update m1_macos_build.yml * Update m1_macos_build.yml Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com> Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com> * Changing detatch disc location Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automation for M1 builds. This creates an unsigned/unnotarized dmg installer. Run on rosetta2 terminal with aws ec2 m1 instance.
Others
pre-commit install.pytest tests/....