Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving styles loading #2569

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Improving styles loading #2569

merged 7 commits into from
Sep 20, 2022

Conversation

Chavithra
Copy link
Contributor

@Chavithra Chavithra commented Sep 20, 2022 •
edited
Loading

Description

Currently version assume that we won't add / remove parameters from default style.
This PR is there to remove that assumption.

@Chavithra Chavithra added the feat XS Extra small feature label Sep 20, 2022
soggyomelette
soggyomelette approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@soggyomelette soggyomelette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Chavithra Chavithra merged commit 017725e into main Sep 20, 2022
@Chavithra Chavithra deleted the fixing_styles branch September 20, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soggyomelette soggyomelette soggyomelette approved these changes

@piiq piiq piiq approved these changes

Assignees
No one assigned
Labels
feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chavithra @piiq @soggyomelette