-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix settings not updating right away #2851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this works, but couldn't you just do |
Yeah I did this wrong. Turns out timezone is the only broken one. My local branch has a lot more progress in fixing. |
When I tried this time zone did not update right away. |
jmaslek
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2676
Currently the TZ setting does not update until the user restarts the terminal. Every other setting updates instantly. I fixed this by updating the environment variable when a user runs this command. Additionally, a bad environment key can currently brick the terminal. I fixed this for some places, but a lot of fixes could still be used.
How has this been tested?
This affects code running at start so it could cause a lot of issues. However, it is only additional error handling and setting an environment variable, which minimizes risk,
tz
commands update instantly I ranpython terminal.py settings tz [TIMEZONE] / h
and confirm the new tz listed matches the one you used.from openbb_terminal.api import openbb
openbb.stocks.candle("TSLA", chart=True)
reports/ stocks btc
Error: 'NoneType' object has no attribute 'options' #2867Checklist:
Others