Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/ov/categories sort options #3335

Merged
merged 7 commits into from
Nov 10, 2022
Merged

crypto/ov/categories sort options #3335

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
03881cb
fixing categories sort options
simmonsj330 Nov 7, 2022
3d7e5ed
Merge branch 'main' into crypto_categories_bug
simmonsj330 Nov 8, 2022
88f3e25
Merge branch 'main' into crypto_categories_bug
simmonsj330 Nov 9, 2022
8273097
Merge branch 'main' into crypto_categories_bug
andrewkenreich Nov 10, 2022
26fa4cd
Merge branch 'main' into crypto_categories_bug
jmaslek Nov 10, 2022
132cfde
edit
jmaslek Nov 10, 2022
5ee9fe9
Merge branch 'main' into crypto_categories_bug
jmaslek Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions openbb_terminal/cryptocurrency/overview/overview_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,16 @@ def __init__(self, queue: List[str] = None):
"--bar": {},
}
choices["categories"] = {
"--sortby": {c: {} for c in pycoingecko_model.CATEGORIES_FILTERS},
"--sortby": {
c: {}
for c in [
"Name",
"Market_Cap",
"Market_Cap_Change_24H",
"Top_3_Coins",
"Volume_24H",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convention is to define this as a self.CATEGORY_SORT_CHOICES then use this here and in the choices

]
},
"-s": "--sortby",
"--limit": {str(c): {} for c in range(1, 100)},
"-l": "--limit",
Expand Down Expand Up @@ -765,8 +774,14 @@ def call_categories(self, other_args):
dest="sortby",
type=str,
help="Sort by given column. Default: market_cap_desc",
default=pycoingecko_model.SORT_VALUES[0],
choices=pycoingecko_model.SORT_VALUES,
default="Market_Cap",
choices=[
"Name",
"Market_Cap",
"Market_Cap_Change_24H",
"Top_3_Coins",
"Volume_24H",
],
)

parser.add_argument(
Expand Down