Sdk dates

openbb_terminal/common/behavioural_analysis/sentimentinvestor_model.py

@@ -128,7 +128,9 @@ def check_supported_ticker(symbol: str) -> bool:
 
 @check_api_key(["API_SENTIMENTINVESTOR_TOKEN"])
 def get_trending(
-    start_date: datetime = datetime.today(), hour: int = 0, number: int = 10
+    start_date: str = datetime.today().strftime("%Y-%m-%d"),
+    hour: int = 0,
+    number: int = 10,
 ) -> pd.DataFrame:
     """Get sentiment data on the most talked about tickers
     within the last hour
@@ -137,8 +139,8 @@ def get_trending(
 
     Parameters
     ----------
-    start_date: datetime
-        Datetime object (e.g. datetime(2021, 12, 21)
+    start_date : str
+        Initial date, format YYYY-MM-DD
     hour: int
         Hour of the day in 24-hour notation (e.g. 14)
     number : int
@@ -152,7 +154,7 @@ def get_trending(
     """
 
     # type is datetime
-    start_timestamp = start_date + timedelta(hours=hour)
+    start_timestamp = datetime.strptime(start_date, "%Y-%m-%d") + timedelta(hours=hour)
 
     payload: Dict[str, Union[int, str]] = {
         "token": cfg.API_SENTIMENTINVESTOR_TOKEN,

openbb_terminal/common/behavioural_analysis/sentimentinvestor_view.py

@@ -146,7 +146,7 @@ def display_historical(
 @log_start_end(log=logger)
 @check_api_key(["API_SENTIMENTINVESTOR_TOKEN"])
 def display_trending(
-    start_date: datetime = datetime.today(),
+    start_date: str = datetime.today().strftime("%Y-%m-%d"),
     hour: int = 0,
     number: int = 10,
     limit: int = 10,
@@ -157,8 +157,8 @@ def display_trending(
 
     Parameters
     ----------
-    start_date: datetime
-        Datetime object (e.g. datetime(2021, 12, 21)
+    start_date : str
+        Initial date, format YYYY-MM-DD
     hour: int
         Hour of the day in 24-hour notation (e.g. 14)
     number : int
@@ -171,10 +171,6 @@ def display_trending(
         Format to export data
     """
 
-    # Force datetime format to be datetime(year, month, day, 0, 0)
-    # 0 hours and minutes to look since day starts
-    start_date = datetime(start_date.year, start_date.month, start_date.day)
-
     df = sentimentinvestor_model.get_trending(start_date, hour, number)
 
     if df.empty:

openbb_terminal/cryptocurrency/cryptocurrency_helpers.py

@@ -123,6 +123,40 @@
 ]
 
 
+def check_datetime(
+    ck_date: datetime | str | None = None, start: bool = True
+) -> datetime:
+    """Checks if given argument is string and attempts to convert to datetime.
+
+    Parameters
+    ----------
+    ck_date : Optional[Union[datetime, str]], optional
+        Date to check, by default None
+    start : bool, optional
+        If True and string is invalid, will return 1100 days ago
+        If False and string is invalid, will return today, by default True
+
+    Returns
+    -------
+    datetime
+        Datetime object
+    """
+    error_catch = (datetime.now() - timedelta(days=1100)) if start else datetime.now()
+    try:
+        if ck_date is None:
+            return error_catch
+        if isinstance(ck_date, datetime):
+            return ck_date
+        if isinstance(ck_date, str):
+            return datetime.strptime(ck_date, "%Y-%m-%d")
+    except Exception:
+        console.print(
+            f"Invalid date format (YYYY-MM-DD), "
+            f"Using {error_catch.strftime('%Y-%m-%d')} for {ck_date}"
+        )
+    return error_catch
+
+
 def _load_coin_map(file_name: str) -> pd.DataFrame:
     if file_name.split(".")[1] != "json":
         raise TypeError("Please load json file")
@@ -472,11 +506,11 @@ def load_from_yahoofinance(
 
 def load(
     symbol: str,
-    start_date: datetime = (datetime.now() - timedelta(days=1100)),
+    start_date: datetime | str | None = None,
     interval: str = "1440",
     exchange: str = "binance",
     vs_currency: str = "usdt",
-    end_date: datetime = datetime.now(),
+    end_date: datetime | str | None = None,
     source: str = "CCXT",
 ) -> pd.DataFrame:
     """Load crypto currency to get data for
@@ -485,17 +519,17 @@ def load(
     ----------
     symbol: str
         Coin to get
-    start_date: datetime
-        The datetime to start at
+    start_date: str or datetime, optional
+        Start date to get data from with. - datetime or string format (YYYY-MM-DD)
     interval: str
         The interval between data points in minutes.
         Choose from: 1, 15, 30, 60, 240, 1440, 10080, 43200
     exchange: str:
         The exchange to get data from.
     vs_currency: str
         Quote Currency (Defaults to usdt)
-    end_date: datetime
-       The datetime to end at
+    end_date: str or datetime, optional
+        End date to get data from with. - datetime or string format (YYYY-MM-DD)
     source: str
         The source of the data
         Choose from: CCXT, CoinGecko, YahooFinance
@@ -505,6 +539,16 @@ def load(
     pd.DataFrame
         Dataframe consisting of price and volume data
     """
+
+    if start_date is None:
+        start_date = (datetime.now() - timedelta(days=1100)).strftime("%Y-%m-%d")
+
+    if end_date is None:
+        end_date = datetime.now().strftime("%Y-%m-%d")
+
+    start_date = check_datetime(start_date)
+    end_date = check_datetime(end_date, start=False)
+
     if source == "CCXT":
         return load_from_ccxt(symbol, start_date, interval, exchange, vs_currency)
     if source == "CoinGecko":

openbb_terminal/cryptocurrency/due_diligence/dd_controller.py

@@ -341,10 +341,11 @@ def call_nonzero(self, other_args: List[str]):
             )
 
             if ns_parser:
+
                 glassnode_view.display_non_zero_addresses(
                     symbol=self.symbol.upper(),
-                    start_date=int(datetime.timestamp(ns_parser.since)),
-                    end_date=int(datetime.timestamp(ns_parser.until)),
+                    start_date=ns_parser.since.strftime("%Y-%m-%d"),
+                    end_date=ns_parser.until.strftime("%Y-%m-%d"),
                     export=ns_parser.export,
                 )
 
@@ -429,11 +430,12 @@ def call_active(self, other_args: List[str]):
             )
 
             if ns_parser:
+
                 glassnode_view.display_active_addresses(
                     symbol=self.symbol.upper(),
                     interval=ns_parser.interval,
-                    start_date=int(datetime.timestamp(ns_parser.since)),
-                    end_date=int(datetime.timestamp(ns_parser.until)),
+                    start_date=ns_parser.since.strftime("%Y-%m-%d"),
+                    end_date=ns_parser.until.strftime("%Y-%m-%d"),
                     export=ns_parser.export,
                 )
 
@@ -493,11 +495,12 @@ def call_change(self, other_args: List[str]):
             )
 
             if ns_parser:
+
                 glassnode_view.display_exchange_net_position_change(
                     symbol=self.symbol.upper(),
                     exchange=ns_parser.exchange,
-                    start_date=int(datetime.timestamp(ns_parser.since)),
-                    end_date=int(datetime.timestamp(ns_parser.until)),
+                    start_date=ns_parser.since.strftime("%Y-%m-%d"),
+                    end_date=ns_parser.until.strftime("%Y-%m-%d"),
                     export=ns_parser.export,
                 )
         else:
@@ -564,11 +567,12 @@ def call_eb(self, other_args: List[str]):
             )
 
             if ns_parser:
+
                 glassnode_view.display_exchange_balances(
                     symbol=self.symbol.upper(),
                     exchange=ns_parser.exchange,
-                    start_date=int(datetime.timestamp(ns_parser.since)),
-                    end_date=int(datetime.timestamp(ns_parser.until)),
+                    start_date=ns_parser.since.strftime("%Y-%m-%d"),
+                    end_date=ns_parser.until.strftime("%Y-%m-%d"),
                     percentage=ns_parser.percentage,
                     export=ns_parser.export,
                 )