Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stocks Suggestor Repair #3477

Merged
merged 45 commits into from
Nov 21, 2022
Merged

Stocks Suggestor Repair #3477

merged 45 commits into from
Nov 21, 2022

Conversation

colin99d
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 18, 2022
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Nov 20, 2022
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Nov 20, 2022
@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label Nov 20, 2022
@Chavithra Chavithra removed feat S Small T-Shirt size Feature feat M Medium T-Shirt size feature feat XS Extra small feature labels Nov 20, 2022
@reviewpad reviewpad bot added the feat XL Extra Large feature label Nov 20, 2022
@colin99d colin99d marked this pull request as ready for review November 21, 2022 11:50
Chavithra
Chavithra approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Chavithra Chavithra merged commit 87458c9 into main Nov 21, 2022
@Chavithra Chavithra deleted the clean_stocks branch November 21, 2022 16:54
noubre pushed a commit to noubre/OpenBBTerminal that referenced this pull request Dec 13, 2022
@colin99d @Chavithra
@northern-64bit @noubre
Stocks Suggestor Repair (OpenBB-finance#3477)
42a0d40 
* broken edition

* Fixed issue

* Update StockController

* Update choices generation

* Update parent_classes

* Update choices generation

* Update choices generation

* Update crypto_controller

* Update DefiController

* Update crypto/disc controller

* Update crypto/dd

* Update choices generation

* Update crypto : dd + nft

* Update crypto/onchain

* Update crypto_controller

* Linting

* Update crypto/ov

* Linting

* Update crypto/ov

* Update crypto/qa

* Update crypto/tools

* Update crypto/ta + dd

* Linting

* Update alt

* Tests fix crypto

* Update future

* Update futures

* Refactored through Options

* Tests + Linting

* finished stocks refactor

* Update stocks/sia

* finished stocks refactor

* Added fixes

* Added fix

* Tests

* Fix conditions

* Fix portfolio

* Prepare for merge

Co-authored-by: Chavithra PARANA <chavithra@gmail.com>
Co-authored-by: northern-64bit <75195383+northern-64bit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@northern-64bit northern-64bit Awaiting requested review from northern-64bit

Assignees
No one assigned
Labels
feat L Large T-Shirt size Feature feat XL Extra Large feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin99d @Chavithra @northern-64bit