Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ins/lip (and others) to show full 100 results on the page #3653

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Nov 29, 2022

As the title says:

@jmaslek jmaslek added the bug Fix bug label Nov 29, 2022
@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label Nov 29, 2022
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather keep the limit arg on the model and have the df.head(limit) also on the model - this way, people can have the same arguments using view/model on the sdk.
Wdyt?

@jmaslek
Copy link
Collaborator Author

jmaslek commented Nov 29, 2022

I would rather keep the limit arg on the model and have the df.head(limit) also on the model - this way, people can have the same arguments using view/model on the sdk. Wdyt?

I lean towards having it in the view. The reasoning is if I am using the SDK and I call the model, I can get as much data as I want without having to worry about adding the limit flag.

@hjoaquim
Copy link
Contributor

I would rather keep the limit arg on the model and have the df.head(limit) also on the model - this way, people can have the same arguments using view/model on the sdk. Wdyt?

I lean towards having it in the view. The reasoning is if I am using the SDK and I call the model, I can get as much data as I want without having to worry about adding the limit flag.

Fair enough!

@jmaslek jmaslek merged commit e044c82 into OpenBB-finance:main Nov 29, 2022
@jmaslek jmaslek deleted the ins_lip branch November 29, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat L Large T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] /stocks/ins Return more than 100 results
2 participants