Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes portfolio/bench #3725

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Fixes portfolio/bench #3725

merged 2 commits into from
Dec 7, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Dec 7, 2022 •
edited
Loading

Description

Fixes #3590

  • Changed choices to the ticker for consistency with the overall terminal

How has this been tested?

openbb/portfolio
bench --benchmark SPY
load --file market.csv
bench --benchmark QQQ
bench -h
reset

@montezdesousa montezdesousa added bug Fix bug portfolio Portfolio menu labels Dec 7, 2022
@montezdesousa montezdesousa requested a review from jmaslek December 7, 2022 15:38
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 7, 2022
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 7, 2022
@jmaslek jmaslek merged commit 77f538c into main Dec 7, 2022
@jmaslek jmaslek deleted the fix3590 branch December 7, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek jmaslek approved these changes

Assignees
No one assigned
Labels
bug Fix bug feat S Small T-Shirt size Feature portfolio Portfolio menu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Portfolio/Bench - Function is broken
2 participants
@montezdesousa @jmaslek