Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty equity report #3739

Merged
merged 8 commits into from
Dec 13, 2022
Merged

Fix empty equity report #3739

merged 8 commits into from
Dec 13, 2022

Conversation

montezdesousa
Copy link
Contributor

Description

Fixes #3702

How has this been tested?

openbb reports
equity --symbol TM
equity --symbol AAPL

@montezdesousa montezdesousa added bug Fix bug notebookreports Notebook reports labels Dec 9, 2022
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Dec 9, 2022
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 9, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Dec 9, 2022

The terminal function now works:

Screenshot 2022-12-09 at 1 49 18 PM

However on equity TM, I get stuck at In[16] which has teh following error

KeyError                                  Traceback (most recent call last)
Cell In [16], line 10
      6             df_analyst["target"] = df_analyst["target_to"].combine_first(
      7                 df_analyst["target"]
      8             )
      9     else:
...
   3808     #  InvalidIndexError. Otherwise we fall through and re-raise
   3809     #  the TypeError.
   3810     self._check_indexing_error(key)

KeyError: 'target_to'

I also note that in this notebook, there is print(df_analyst.columns) -- which was probably left over from a debug statement?

@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 12, 2022
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 12, 2022
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 12, 2022
@montezdesousa
Copy link
Contributor Author

montezdesousa commented Dec 12, 2022

The terminal function now works:

Screenshot 2022-12-09 at 1 49 18 PM

However on equity TM, I get stuck at In[16] which has teh following error

KeyError                                  Traceback (most recent call last)
Cell In [16], line 10
      6             df_analyst["target"] = df_analyst["target_to"].combine_first(
      7                 df_analyst["target"]
      8             )
      9     else:
...
   3808     #  InvalidIndexError. Otherwise we fall through and re-raise
   3809     #  the TypeError.
   3810     self._check_indexing_error(key)

KeyError: 'target_to'

I also note that in this notebook, there is print(df_analyst.columns) -- which was probably left over from a debug statement?

Forgot to indent that block, can you see if it works now? Seems to be good on my side with TM, AAPL or default

@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 12, 2022
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end now

@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Dec 12, 2022
@jmaslek jmaslek merged commit 6d88b51 into main Dec 13, 2022
@jmaslek jmaslek deleted the empty_reports branch December 13, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat S Small T-Shirt size Feature notebookreports Notebook reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] stocks/dd/est error handling causes equity report to fail [for "TM" (toyota) ticker]
2 participants