Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small options fix + docstring #3792

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Small options fix + docstring #3792

merged 3 commits into from
Dec 16, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Dec 16, 2022

  1. Fix the greek calculation in chains where we were using .seconds instead of .total_seconds
  2. Change the time to expiration calculation in options to be 4PM instead of midnight am (hence the + 16 hours)
  3. Fix the typo I reverted from @hjoaquim

@jmaslek jmaslek added the bug Fix bug label Dec 16, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 16, 2022
@jmaslek jmaslek requested a review from hjoaquim December 16, 2022 00:48
@hjoaquim
Copy link
Contributor

No worries 😆

@hjoaquim hjoaquim merged commit d99c549 into OpenBB-finance:main Dec 16, 2022
This was referenced Dec 21, 2022
Merged
Closed
@jmaslek jmaslek deleted the small_things branch February 14, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees
No one assigned
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaslek @hjoaquim