Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ValueError in Cell 21. #3804

Merged
merged 7 commits into from
Dec 24, 2022
Merged

Fixes ValueError in Cell 21. #3804

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c1fd74
Fixes ValueError in Cell 21.
joshuabuildsthings Dec 20, 2022
da750c5
Fixes ValueError in Cell 21.
joshuabuildsthings Dec 20, 2022
cfb0ba4
Merge branch 'fix/economy-report-error-09717374' of github.com:joshua…
joshuabuildsthings Dec 20, 2022
dcfab14
Merge branch 'fix/economy-report-error-09717374' of github.com:joshua…
joshuabuildsthings Dec 20, 2022
58b2fdf
Merge branch 'main' into fix/economy-report-error-09717374
joshuabuildsthings Dec 21, 2022
f4a382a
Clearing cells
joshuabuildsthings Dec 21, 2022
66b0afc
Merge branch 'main' into fix/economy-report-error-09717374
joshuabuildsthings Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions openbb_terminal/reports/templates/economy.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,22 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 1,
"id": "driven-billion",
"metadata": {},
"outputs": [],
"outputs": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to get rid of these?

{
"ename": "ModuleNotFoundError",
"evalue": "No module named 'openbb_terminal'",
"output_type": "error",
"traceback": [
"\u001b[1;31m---------------------------------------------------------------------------\u001b[0m",
"\u001b[1;31mModuleNotFoundError\u001b[0m Traceback (most recent call last)",
"Cell \u001b[1;32mIn [1], line 16\u001b[0m\n\u001b[0;32m 12\u001b[0m \u001b[39mimport\u001b[39;00m \u001b[39mmatplotlib_inline\u001b[39;00m\u001b[39m.\u001b[39;00m\u001b[39mbackend_inline\u001b[39;00m\n\u001b[0;32m 14\u001b[0m \u001b[39mfrom\u001b[39;00m \u001b[39mIPython\u001b[39;00m\u001b[39m.\u001b[39;00m\u001b[39mdisplay\u001b[39;00m \u001b[39mimport\u001b[39;00m HTML\n\u001b[1;32m---> 16\u001b[0m \u001b[39mfrom\u001b[39;00m \u001b[39mopenbb_terminal\u001b[39;00m\u001b[39m.\u001b[39;00m\u001b[39mreports\u001b[39;00m \u001b[39mimport\u001b[39;00m widget_helpers \u001b[39mas\u001b[39;00m widgets\n\u001b[0;32m 17\u001b[0m \u001b[39mfrom\u001b[39;00m \u001b[39mopenbb_terminal\u001b[39;00m\u001b[39m.\u001b[39;00m\u001b[39msdk\u001b[39;00m \u001b[39mimport\u001b[39;00m openbb\n\u001b[0;32m 18\u001b[0m \u001b[39mfrom\u001b[39;00m \u001b[39mopenbb_terminal\u001b[39;00m\u001b[39m.\u001b[39;00m\u001b[39mhelper_funcs\u001b[39;00m \u001b[39mimport\u001b[39;00m get_user_timezone\n",
"\u001b[1;31mModuleNotFoundError\u001b[0m: No module named 'openbb_terminal'"
]
}
],
"source": [
"import os\n",
"import io\n",
Expand Down Expand Up @@ -554,7 +566,7 @@
" fig.savefig(f, format=\"svg\")\n",
" fred_0 = f.getvalue().decode(\"utf-8\")\n",
"else:\n",
" fred = pd.DataFrame()"
" fred = None"
]
},
{
Expand Down Expand Up @@ -681,7 +693,7 @@
"metadata": {
"celltoolbar": "Tags",
"kernelspec": {
"display_name": "obb-full",
"display_name": "obb",
"language": "python",
"name": "python3"
},
Expand All @@ -695,11 +707,11 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.6"
"version": "3.9.6 | packaged by conda-forge | (default, Jul 11 2021, 03:37:25) [MSC v.1916 64 bit (AMD64)]"
},
"vscode": {
"interpreter": {
"hash": "73442d10f374b1f81e7aab42e2dddb832a354757dce244164d617e7faf60ecd1"
"hash": "5884d32f23cebd85614e61b7b7ae47cd3ddb4b608302151a537f0a43f338bd80"
}
}
},
Expand Down