Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blcp display name #3808

Merged
merged 7 commits into from
Dec 22, 2022
Merged

Update blcp display name #3808

merged 7 commits into from
Dec 22, 2022

Conversation

Drinkler
Copy link
Contributor

@Drinkler Drinkler commented Dec 20, 2022

Description

This PR updates the display name of the blcp command inside the stocks/ins (Stocks - Insider Trading) menu.

Related to issue #3807.

How has this been tested?

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 20, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Dec 21, 2022

Hey nice catch!

In order to pass the tests, we just need to rewrite the menu help text, which can be done by:

pytest tests/openbb_terminal/stocks/insider/test_insider_controller.py --rewrite-expected

@Drinkler
Copy link
Contributor Author

Drinkler commented Dec 21, 2022

Hey nice catch!

In order to pass the tests, we just need to rewrite the menu help text, which can be done by:

pytest tests/openbb_terminal/stocks/insider/test_insider_controller.py --rewrite-expected

Thanks, I was just trying to understand and fix this error :D This helped a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants