Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.0 #3811

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Release 2.1.0 #3811

merged 5 commits into from
Dec 21, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Dec 21, 2022

:)

@jmaslek jmaslek added the build Build-related work label Dec 21, 2022
@jmaslek jmaslek requested review from Chavithra and piiq December 21, 2022 17:03
@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 21, 2022
@piiq piiq changed the title bump version to 2.1.0 Release 2.1.0 Dec 21, 2022
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@piiq
Copy link
Contributor

piiq commented Dec 21, 2022

Give us a minute please, we're debugging what's wrong with reviewpad with @ferreiratiago

@ferreiratiago
Copy link
Contributor

Give us a minute please, we're debugging what's wrong with reviewpad with @ferreiratiago

We're sorry that reviewpad is not behaving as expected.

This problem is happening because the file pyproject.toml is being changed but the files requirements.txt and requirements-full.txt are not.

This causes the reviewpad workflow dependencies to be triggered, which makes reviewpad to create a code review requesting changes. Due to a bug, that action is not being performed successfully and reviewpad fails.

The action here can be:
(1) Update the files requirements.txt and requirements-full.txt. I'm assuming that is something that needs to be done.
(2) Disable the reviewpad workflow dependencies. This requires opening a pull request updating reviewpad.
(3) Kindly ask you to ignore reviewpad execution for this pull request.

We are working on a fix for this issue and it will be shipped on the next version of Reviewpad (to be released tomorrow).

Please let me know if this helps. Sorry 🙏

@jmaslek jmaslek merged commit 7e90d20 into main Dec 21, 2022
@jmaslek jmaslek deleted the release/2.1.0 branch December 21, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related work feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants