Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command to check top hackernews stories #3841

Merged
merged 25 commits into from
Jan 3, 2023
Merged

Adds command to check top hackernews stories #3841

merged 25 commits into from
Jan 3, 2023

Conversation

jose-donato
Copy link
Contributor

@jose-donato jose-donato commented Dec 29, 2022

Description

image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@jose-donato jose-donato added the feat XS Extra small feature label Dec 29, 2022
@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat XS Extra small feature labels Dec 29, 2022
logger = logging.getLogger(__name__)


def get_stories(limit: int = 10) -> pd.DataFrame:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add the log_start_end decorator here

@jmaslek jmaslek merged commit d9267da into main Jan 3, 2023
@jmaslek jmaslek deleted the hackernews branch January 3, 2023 21:57
@jose-donato
Copy link
Contributor Author

@JerBouma this PR could go to contributing guidelines on how to add a new feature to the terminal. i did strictly that here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat L Large T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants