New functionality for UK Sold house price data #3969

kulbinderdio · 2023-01-14T21:56:45Z

Description

[ New functionality under Alternative to retrieve UK sold house price data] Summary of the change / bug fix.
Link # issue, if applicable.
[

] Screenshot of the feature or the bug before/after fix, if applicable. - [ ] Relevant motivation and context. - [ SPARQLWrapper] List any dependencies that are required for this change.

How has this been tested?

Please describe the tests that you ran to verify your changes.
Have ran all commands from application and also created a test class
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

Make sure affected commands still run in terminal
Ensure the SDK still works
Check any related reports

Checklist:

Update our Hugo documentation following these guidelines.
Update our tests following these guidelines.
Make sure you are following our CONTRIBUTING guidelines.
If a feature was added make sure to add it to the corresponding scripts file.

Others

[ x] I have performed a self-review of my own code.
[ x] I have commented my code, particularly in hard-to-understand areas.

…/OpenBBTerminal into feature/real_estate

kulbinderdio · 2023-01-20T20:30:21Z

Hi, is there something else required for me to do now?

jmaslek · 2023-01-26T01:26:53Z

Sorry for the long delay. Will go through now.

First thing I see is that in the menu:

│                                                                                                                                      │
│     sales              list UK house sales via postcode                                                                              │
│                                                                                                                                      │
│ alternative/realestate/_postcode:                                                                                                    │
│                                                                                                                                      │
│     townsales          list UK house sales via town                                                                                  │
│                                                                                                                                      │
│ alternative/realestate/_town:                                                                                                        │
│ alternative/realestate/_startdate <YYYY-MM-DD>:                                                                                      │
│ alternative/realestate/_enddate <YYYY-MM-DD>:                                                                                        │
│                                                                                                                                      │
│     regionstats        retrieve UK sold house price stats by region                                                                  │
│                                                                                                                                      │
│ alternative/realestate/_region:                                                                                                      │
│ alternative/realestate/_startdate <YYYY-MM-DD>:                                                                                      │
│ alternative/realestate/_enddate <YYYY-MM-DD>:

Looks like you are missing the entries for the _town/_start etc in the i18 file.

jmaslek · 2023-01-26T01:28:53Z

openbb_terminal/alternative/realestate/realestate_controller.py

+        else:
+            console.print("[red]Select valid postcode[/red]\n")


This doesn't need to be here. This triggers the select valid postcode.

jmaslek · 2023-01-26T01:29:05Z

If i look for help :

2023 Jan 25, 20:27 (🦋) /alternative/realestate/ $ sales -h

usage: sales [-p postcode] [-h] [--export EXPORT] [--sheet-name SHEET_NAME [SHEET_NAME ...]]

Select the postcode you want to see sold house price data for. [Source: UK Land Registry]

optional arguments:
  -p postcode, --postcode postcode
                        Postcode (default: None)
  -h, --help            show this help message (default: False)
  --export EXPORT       Export raw data into csv, json, xlsx (default: )
  --sheet-name SHEET_NAME [SHEET_NAME ...]
                        Name of excel sheet to save data to. Only valid for .xlsx files. (default: None)

For more information and examples, use 'about sales' to access the related guide.

Select valid postcode

The select valid postcode shouldnt appear if we have the -h flag. I pointed out where this happens in the code

jmaslek · 2023-01-26T01:29:44Z

If i look for help :

2023 Jan 25, 20:27 (🦋) /alternative/realestate/ $ sales -h

usage: sales [-p postcode] [-h] [--export EXPORT] [--sheet-name SHEET_NAME [SHEET_NAME ...]]

Select the postcode you want to see sold house price data for. [Source: UK Land Registry]

optional arguments:
  -p postcode, --postcode postcode
                        Postcode (default: None)
  -h, --help            show this help message (default: False)
  --export EXPORT       Export raw data into csv, json, xlsx (default: )
  --sheet-name SHEET_NAME [SHEET_NAME ...]
                        Name of excel sheet to save data to. Only valid for .xlsx files. (default: None)

For more information and examples, use 'about sales' to access the related guide.

Select valid postcode

The select valid postcode shouldnt appear if we have the -h flag. I pointed out where this happens in the code

If i look for help :

2023 Jan 25, 20:27 (🦋) /alternative/realestate/ $ sales -h

usage: sales [-p postcode] [-h] [--export EXPORT] [--sheet-name SHEET_NAME [SHEET_NAME ...]]

Select the postcode you want to see sold house price data for. [Source: UK Land Registry]

optional arguments:
  -p postcode, --postcode postcode
                        Postcode (default: None)
  -h, --help            show this help message (default: False)
  --export EXPORT       Export raw data into csv, json, xlsx (default: )
  --sheet-name SHEET_NAME [SHEET_NAME ...]
                        Name of excel sheet to save data to. Only valid for .xlsx files. (default: None)

For more information and examples, use 'about sales' to access the related guide.

Select valid postcode

The select valid postcode shouldnt appear if we have the -h flag. I pointed out where this happens in the code

This happens for all other functions.

jmaslek · 2023-01-26T01:40:31Z

These functions should have a limit in the views. For example, I run townsales -t London -s 2022-01-01 -e 2022-01-10 and it populated my whole IDE.

additionally, we probably want to specify a default start and end date (if I do townsales -t London it should work, but it currently does not)

…/OpenBBTerminal into feature/real_estate

kulbinderdio · 2023-01-30T22:13:30Z

default limit values added to model functions.

kulbinderdio · 2023-02-01T15:46:32Z

I just applied a branch update and now I'm getting Linting errors in my controller that is a new file but was formatted ok prior to the branch update. Since the file is new and only in my pull request don't understand why it is failing now

jmaslek · 2023-02-01T15:50:33Z

I just applied a branch update and now I'm getting Linting errors in my controller that is a new file but was formatted ok prior to the branch update. Since the file is new and only in my pull request don't understand why it is failing now

The black formatter published a new version last night, which is what gets installed on the linter. You can locally run pip install -U black then reformat to fix

kulbinderdio · 2023-02-01T17:55:39Z

Reviewpad failed with the error API rate limit exceeded for installation ID 30911239.

jmaslek · 2023-02-02T15:37:06Z

Sorry for the delay. Was busy getting that last release fixed. If you fix the merge conflicts, I will give a final look today!

kulbinderdio · 2023-02-02T18:01:27Z

Have resolved merge issues but now failing on some security checks I haven't seen before to do with Snyk.

jmaslek · 2023-02-02T18:26:47Z

Something is still not correct with the poetry lock.The unit test check is failing on install dependencies.

poetry export -f requirements.txt -E optimization --without-hashes --output requirements.txt
poetry export -f requirements.txt --dev -E all --without-hashes --output requirements-full.txt

kulbinderdio · 2023-02-02T19:15:17Z

I ran the poetry export commands and can't see any install errors but can see that some of not tests were skipped. Not sure how to resolve.

jmaslek · 2023-02-02T20:10:49Z

I ran the poetry export commands and can't see any install errors but can see that some of not tests were skipped. Not sure how to resolve.

ill take a stab at

jmaslek · 2023-02-02T20:23:53Z

I ran the poetry export commands and can't see any install errors but can see that some of not tests were skipped. Not sure how to resolve.

Everything was good on the update. Not sure what the snyk issues are, but I can ignore them for now. I just added a test script for our end and the rest looks good!

jmaslek

Thanks for your patience!

kulbinderdio · 2023-02-02T21:23:07Z

No problem. I know you're busy.
Thanks a lot for your help. Been over a decade since I last worked on a large multi developer project.

New functionality for UK Sold house price data

2308683

reviewpad bot added the feat M Medium T-Shirt size feature label Jan 14, 2023

kulbinderdio added 3 commits January 14, 2023 22:25

test_ alt_controller fixed (output check (extra spaces removed)

8dc9f0e

added newline to ends of files to pass Code Linting

069dc21

newlines added for Linting

403283f

luqmanbello changed the base branch from develop to main January 16, 2023 14:35

luqmanbello changed the base branch from main to develop January 16, 2023 14:35

reviewpad bot added feat XL Extra Large feature feat M Medium T-Shirt size feature and removed feat M Medium T-Shirt size feature feat XL Extra Large feature labels Jan 16, 2023

luqmanbello and others added 9 commits January 16, 2023 16:54

Merge branch 'develop' into feature/real_estate

1ace755

Merge branch 'OpenBB-finance:develop' into feature/real_estate

e7eb820

more newlines for linting

4cd7aeb

Merge branch 'feature/real_estate' of https://github.com/kulbinderdio…

8e4d634

…/OpenBBTerminal into feature/real_estate

trying again to resolve linting issue

e585659

and once more with black installed

fc43e62

still trying to resolve linting issues

308b0a6

still trying to resolve linting issues

5276606

Merge branch 'develop' into feature/real_estate

378b13f

Chavithra self-requested a review January 17, 2023 16:54

kulbinderdio and others added 2 commits January 24, 2023 17:25

Merge branch 'develop' into feature/real_estate

e2bbd40

Merge branch 'develop' into feature/real_estate

c5949a4

jmaslek reviewed Jan 26, 2023

View reviewed changes

Limit to rows returned and more use of default values

16c64e9

jmaslek and others added 3 commits January 30, 2023 13:24

Merge branch 'develop' into feature/real_estate

286e7bb

format changes by black

41da657

Merge branch 'feature/real_estate' of https://github.com/kulbinderdio…

68e1662

…/OpenBBTerminal into feature/real_estate

kulbinderdio added 3 commits January 31, 2023 14:48

Merge branch 'develop' into feature/real_estate

a4962e9

Merge branch 'develop' into feature/real_estate

8340543

Merge branch 'develop' into feature/real_estate

6678d3a

kulbinderdio added 2 commits February 1, 2023 17:14

Merge branch 'develop' into feature/real_estate

1839482

Linting changes

3da198b

issue with poetry.lock after merge

e84cef7

kulbinderdio added 3 commits February 2, 2023 17:37

Merge branch 'develop' into feature/real_estate

58e60ca

Correct merge issue

7bb8b7c

merge issue resolution

3054e16

trying to resolve merge issues

593972c

integration script

985b652

jmaslek approved these changes Feb 2, 2023

View reviewed changes

jmaslek added 2 commits February 2, 2023 15:27

Merge branch 'develop' into feature/real_estate

867f36d

Merge branch 'develop' into feature/real_estate

d743115

jmaslek merged commit 3664291 into OpenBB-finance:develop Feb 2, 2023

kulbinderdio deleted the feature/real_estate branch February 9, 2023 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New functionality for UK Sold house price data #3969

New functionality for UK Sold house price data #3969

kulbinderdio commented Jan 14, 2023

kulbinderdio commented Jan 20, 2023

jmaslek commented Jan 26, 2023

jmaslek Jan 26, 2023

jmaslek commented Jan 26, 2023

jmaslek commented Jan 26, 2023

jmaslek commented Jan 26, 2023

kulbinderdio commented Jan 30, 2023

kulbinderdio commented Feb 1, 2023

jmaslek commented Feb 1, 2023

kulbinderdio commented Feb 1, 2023

jmaslek commented Feb 2, 2023

kulbinderdio commented Feb 2, 2023

jmaslek commented Feb 2, 2023

kulbinderdio commented Feb 2, 2023

jmaslek commented Feb 2, 2023

jmaslek commented Feb 2, 2023

jmaslek left a comment

kulbinderdio commented Feb 2, 2023

New functionality for UK Sold house price data #3969

New functionality for UK Sold house price data #3969

Conversation

kulbinderdio commented Jan 14, 2023

Description

How has this been tested?

Checklist:

Others

kulbinderdio commented Jan 20, 2023

jmaslek commented Jan 26, 2023

jmaslek Jan 26, 2023

Choose a reason for hiding this comment

jmaslek commented Jan 26, 2023

jmaslek commented Jan 26, 2023

jmaslek commented Jan 26, 2023

kulbinderdio commented Jan 30, 2023

kulbinderdio commented Feb 1, 2023

jmaslek commented Feb 1, 2023

kulbinderdio commented Feb 1, 2023

jmaslek commented Feb 2, 2023

kulbinderdio commented Feb 2, 2023

jmaslek commented Feb 2, 2023

kulbinderdio commented Feb 2, 2023

jmaslek commented Feb 2, 2023

jmaslek commented Feb 2, 2023

jmaslek left a comment

Choose a reason for hiding this comment

kulbinderdio commented Feb 2, 2023