-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds crypto fees revenue command #4067
Conversation
raise Exception(f"Status code: {response.status_code}. Reason: {response.text}") | ||
try: | ||
df = pd.DataFrame(response.json()) | ||
df.replace({float(np.nan): None}, inplace=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inplace=True is bad, You should also use fillna
export_data( | ||
export, | ||
os.path.dirname(os.path.abspath(__file__)), | ||
"fees", | ||
df, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sheet name argument
) | ||
|
||
parser.add_argument( | ||
"-mc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not have 2 letters on single dash argument
help="Include the market cap rank", | ||
) | ||
parser.add_argument( | ||
"-tvl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
…finance/OpenBBTerminal into feature/cryptostats_fees
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4067 +/- ##
===========================================
- Coverage 58.29% 58.06% -0.24%
===========================================
Files 588 590 +2
Lines 53666 53921 +255
===========================================
+ Hits 31283 31307 +24
- Misses 22383 22614 +231
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the source and then its picasso level beauty
@jmaslek fixed the tests related to this pr |
…minal into feature/cryptostats_fees
…finance/OpenBBTerminal into feature/cryptostats_fees
Description
Integrates crypto fees revenue adapter from @CryptoStats_. There are many other adapters (FREE) that we can integrate from cryptostats
Still need to:
How has this been tested?
Checklist:
Others