Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change integration tests environment variables + add option #4126

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Change integration tests environment variables + add option #4126

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
628864f
remove quick exit + prompt
montezdesousa Feb 3, 2023
7314166
prompt toolkit is fine
montezdesousa Feb 3, 2023
8df54ed
ion true, otherwise integration tests hang when plot is not close
montezdesousa Feb 3, 2023
f4b9017
add option to run silent mode + sequential
montezdesousa Feb 3, 2023
1bf689d
enable quick exit false explicit
montezdesousa Feb 3, 2023
704eadb
Merge branch 'develop' into hotfix/unblock_integ_tests
montezdesousa Feb 3, 2023
642360d
Update integration_controller.py
montezdesousa Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions openbb_terminal/core/integration_tests/integration_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
MISCELLANEOUS_DIRECTORY,
REPOSITORY_DIRECTORY,
)
from openbb_terminal.helper_funcs import check_positive
from openbb_terminal.helper_funcs import check_non_negative
from openbb_terminal.rich_config import console
from openbb_terminal.terminal_controller import (
insert_start_slash,
Expand Down Expand Up @@ -370,7 +370,6 @@ def run_test_files(
-------
Tuple[int, int, Dict[str, Dict[str, Any]], float]
"""
os.environ["DEBUG_MODE"] = "true"
n_successes = 0
n_failures = 0
fails: Dict[str, Dict[str, Any]] = {}
Expand All @@ -380,7 +379,7 @@ def run_test_files(

start = time.time()

if verbose and not subprocesses:
if subprocesses == 0:
console.print(
f"* Running {n} script(s) sequentially...\n",
style="bold",
Expand Down Expand Up @@ -634,7 +633,7 @@ def parse_args_and_run():
help="The number of subprocesses to use to run the tests."
" Default is the minimum between number of collected scripts and CPUs.",
dest="subprocesses",
type=check_positive,
type=check_non_negative,
default=None,
)
parser.add_argument(
Expand Down Expand Up @@ -662,12 +661,13 @@ def parse_args_and_run():

special_args_dict = {x: getattr(ns_parser, x) for x in special_arguments_values}

if ns_parser.verbose and ns_parser.subprocesses:
console.print(
"WARNING: verbose mode and multiprocessing are not compatible. "
"The output of the scripts is mixed up. Consider running without --subproc.\n",
style="yellow",
)
if ns_parser.verbose:
if ns_parser.subprocesses is None or ns_parser.subprocesses > 0:
console.print(
"WARNING: verbose mode and multiprocessing are not compatible. "
"The output of the scripts is mixed up. Consider running with --subproc 0.\n",
style="yellow",
)

if ns_parser.list_:
return display_available_scripts(ns_parser.path, ns_parser.skip)
Expand All @@ -689,10 +689,11 @@ def main():
if "--test" in sys.argv:
sys.argv.remove("--test")

os.environ["OPENBB_ENABLE_QUICK_EXIT"] = "True"
os.environ["OPENBB_ENABLE_QUICK_EXIT"] = "False"
os.environ["OPENBB_LOG_COLLECT"] = "False"
os.environ["OPENBB_USE_ION"] = "False"
os.environ["OPENBB_USE_ION"] = "True"
os.environ["OPENBB_USE_PROMPT_TOOLKIT"] = "False"
os.environ["DEBUG_MODE"] = "True"

parse_args_and_run()

Expand Down