Adjust timezone for AV when interval < 1d

[hjoaquim]

Description

• Summary of the change / bug fix.
  Adjust timezone to user config on loading a fx pair from AV.

• Link # issue, if applicable.
  Fix [Bug] Forex/Load --source AlphaVantage: Timestamp is wrong, five hours ahead of now. #3883

• Screenshot of the feature or the bug before/after fix, if applicable.

• Relevant motivation and context.
  🐛 ☠️

• List any dependencies that are required for this change.
  NA

How has this been tested?

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

• Make sure affected commands still run in terminal
• Ensure the SDK still works

from openbb_terminal.sdk import openbb
openbb.forex.load(
    from_symbol="EUR", 
    to_symbol="USD", 
    start_date="2020-11-30", 
    end_date="2022-12-01",
    source="AlphaVantage"
)

TODO:

• Test with an interval < 1d

• Check any related reports

Checklist:

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[hjoaquim]

@deeleeramone would you please give me a help trying this out?

I don't have access to premium endpoints 😫 :

2023 Feb 07, 13:03 (🦋) /forex/ $ load JPYUSD --source AlphaVantage --interval 15min

Thank you for using Alpha Vantage! This is a premium endpoint. You may subscribe to any of the premium plans at https://www.alphavantage.co/premium/ to instantly unlock all premium endpoints

No historical data loaded.

Make sure you have appropriate access for the 'AlphaVantage' data source and that 'AlphaVantage' supports the requested range.

2023 Feb 07, 13:08 (🦋) /forex/ $

[jmaslek]

NOt a bug, but I am noticing that we don't grab adjusted when it is available: https://www.alphavantage.co/documentation/#dailyadj:

[jmaslek]

I uhhhh dont have a premium key either but it works. Its 19:20 locally and that looks like the latest timestamp when it previously was utc

[deeleeramone]

I get no timestamp and some weird column, Date_Id

2023 Feb 07, 19:27 (🦋) /forex/ $ candle --raw

                                         Raw Data                                          
┏━━━━━━━━━━━━┳━━━━━━━┳━━━━━━━┳━━━━━━━┳━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━┳━━━━━━━┳━━━━━━━┓
┃            ┃ Open  ┃ High  ┃ Low   ┃ Close ┃ Date_Id ┃ Oc_High ┃ Oc_Low ┃ Ma20  ┃ Ma50  ┃
┡━━━━━━━━━━━━╇━━━━━━━╇━━━━━━━╇━━━━━━━╇━━━━━━━╇━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━╇━━━━━━━╇━━━━━━━┩
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
├────────────┼───────┼───────┼───────┼───────┼─────────┼─────────┼────────┼───────┼───────┤
│ 2023-02-07 │ 0.008 │ 0.008 │ 0.008 │ 0.008 │ 6.000   │ 0.008   │ 0.008  │ 0.008 │ 0.008 │
└────────────┴───────┴───────┴───────┴───────┴─────────┴─────────┴────────┴───────┴───────┘

2023 Feb 07, 19:26 (🦋) /forex/ $ load JPYUSD --source AlphaVantage -i 5min

JPY-USD loaded.

[jmaslek]

guess not fixed per danglewood

[hjoaquim]

Not a bug, but I am noticing that we don't grab adjusted when it is available: https://www.alphavantage.co/documentation/#dailyadj:

Guess those are just for stocks? But indeed, we might want to use it!

[hjoaquim]

I get no timestamp and some weird column, Date_Id

I think the default behavior is to not show tz info on the candle --raw?
So we'll need to look to the candle chart itself or export it to a csv:

Regarding the column Date_Id, not sure of what it represents or if it's useful - but does not relate with our discussion on the timezone.

[hjoaquim]

^ regarding my last comment, it seems that Date_Id is then used on stocks_helper.find_tendline

[jmaslek]

I get no timestamp and some weird column, Date_Id

I think the default behavior is to not show tz info on the candle --raw? So we'll need to look to the candle chart itself or export it to a csv:

In qa_view.display_raw we have the following:

df1.index = [x.strftime("%Y-%m-%d") for x in df1.index]

Note this applies to all of our candle functions (doing load -i 1 on stocks then candle raw shows this as well).

The extra columns are because we dont copy the df when we do the prepare candle stuff/

Since the ticket is for tz, this solves it. Can open a new ticket for tz in candle raw

[hjoaquim]

Can open a new ticket for tz in candle raw

Agreed. Will be a cool little detail we can add let's say with some flag