Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restores numeric values #4183

Merged
merged 15 commits into from
Feb 9, 2023
Merged

Restores numeric values #4183

merged 15 commits into from
Feb 9, 2023

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Feb 9, 2023

This PR aims to remove the formatting that sometimes is done in order to beautifully present tables in the terminal - which latter causes numeric values to be presented as alphanumeric (specially in Excel sheets).

Fix #3872

Also took to opportunity to do a minor cleaning on helper_funcs.py

@hjoaquim hjoaquim added the enhancement Enhancement label Feb 9, 2023
@hjoaquim hjoaquim requested review from jmaslek and JerBouma February 9, 2023 10:32
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Feb 9, 2023
@JerBouma
Copy link
Contributor

JerBouma commented Feb 9, 2023

I'll look at this in a bit thank you.

@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat S Small T-Shirt size Feature labels Feb 9, 2023
JerBouma
JerBouma approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, this is really great and helpful.

@jmaslek jmaslek enabled auto-merge February 9, 2023 20:18
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XL Extra Large feature labels Feb 9, 2023
@jmaslek jmaslek added this pull request to the merge queue Feb 9, 2023
@jmaslek jmaslek removed this pull request from the merge queue due to the queue being cleared Feb 9, 2023
@jmaslek jmaslek merged commit f143f83 into OpenBB-finance:develop Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JerBouma JerBouma JerBouma approved these changes

@jmaslek jmaslek Awaiting requested review from jmaslek

Assignees
No one assigned
Labels
enhancement Enhancement feat S Small T-Shirt size Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IMPROVE] Ensure all exports to Excel are always numbers and not strings
3 participants
@hjoaquim @JerBouma @jmaslek