Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage #4236

Merged
merged 19 commits into from
Feb 17, 2023
Merged

Code Coverage #4236

merged 19 commits into from
Feb 17, 2023

Conversation

luqmanbello
Copy link
Contributor

  • Implement code coverage

@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 14, 2023
@Chavithra Chavithra self-requested a review February 14, 2023 13:42
@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat XS Extra small feature labels Feb 16, 2023
@Chavithra
Copy link
Contributor

Chavithra commented Feb 16, 2023

Hi @luqmanbello,

fixed the tests.

I think we should combine "coverage" CI and tests CI.

Or something like this to avoid running the tests twice.

Thanks

Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@luqmanbello
Copy link
Contributor Author

Hi @luqmanbello,

fixed the tests.

I think we should combine "coverage" CI and tests CI.

Or something like this to avoid running the tests twice.

Thanks

Since we are not enforcing it yet, we can combine it with the unit test

@jmaslek
Copy link
Collaborator

jmaslek commented Feb 17, 2023

Should we have the code cov depend on the check for changes so that the tests arent running when no .py files are changed?

@luqmanbello
Copy link
Contributor Author

Should we have the code cov depend on the check for changes so that the tests arent running when no .py files are changed?

That's what I just implemented. it will also only run on the base-test

@luqmanbello luqmanbello merged commit bbeaef4 into develop Feb 17, 2023
@luqmanbello luqmanbello deleted the feature/code-coverage branch February 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat L Large T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants