-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Coverage #4236
Code Coverage #4236
Conversation
luqmanbello
commented
Feb 14, 2023
- Implement code coverage
Hi @luqmanbello, fixed the tests. I think we should combine "coverage" CI and tests CI. Or something like this to avoid running the tests twice. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
Since we are not enforcing it yet, we can combine it with the unit test |
Should we have the code cov depend on the check for changes so that the tests arent running when no .py files are changed? |
That's what I just implemented. it will also only run on the |