Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/rvol model #4371

Merged
merged 15 commits into from
Mar 2, 2023
Merged

Hotfix/rvol model #4371

merged 15 commits into from
Mar 2, 2023

Conversation

deeleeramone
Copy link
Contributor

This patch makes the trading_periods parameter Optional, and provides true override with an indicating message.

Changes are for each model:

    if trading_periods and is_crypto:
        print("is_crypto is overriden by trading_periods.")

    if not trading_periods:
        trading_periods = 365 if is_crypto else 252

Screenshot 2023-03-01 at 10 28 38 PM

Screenshot 2023-03-01 at 10 39 00 PM

@deeleeramone deeleeramone added the enhancement Enhancement label Mar 2, 2023
@deeleeramone deeleeramone requested a review from jmaslek March 2, 2023 06:44
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 2, 2023
@jmaslek jmaslek merged commit a6951bd into develop Mar 2, 2023
@jmaslek jmaslek deleted the hotfix/rvol_model branch March 2, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants