Delete everything related to the Sector and Industry Analysis menu #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaslek
approved these changes
Mar 2, 2023
jmaslek
added a commit
that referenced
this pull request
Apr 13, 2023
…4374) * Get rid of sia * Remove Portfolio Analysis menu that was not being used * Remove Portfolio Analysis menu that was not being used * That comment about GitHub datasets failing to load included sia, removed that --------- Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes little sense to keep the code of
siaaround. Even if you would want to enable it, it suffers from a lot of broken functionality or simply outdated code given our current structure elsewhere. You'd also really do not want to have to update all of this for v4.0. Might as well delete the whole thing especially since there are bugs with cloning currently as reported here #4373.It deletes: