Update helper_classes.py bug on line 126 #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
branch name |
jmaslek
approved these changes
Mar 6, 2023
JerBouma
pushed a commit
that referenced
this pull request
Mar 6, 2023
Co-authored-by: James Maslek <jmaslek11@gmail.com>
JerBouma
added a commit
that referenced
this pull request
Mar 9, 2023
…quirements and more (#4382) * fix: changed button styles * Make Rosetta requirements more clear * Update installation instructions * Add seperation * Update windows.md * Update installation docs * fix country choices (#4403) * Hotfix/plotsbackend start (#4404) * readd removed plots_backend().start() from merged PR * Update backend.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Update helper_classes.py (#4378) Co-authored-by: James Maslek <jmaslek11@gmail.com> * Add improvements to the website * Fix keys wrong redirect * Update installation * Update requirements * move things around * Restructure everything * Details * fix: mac issue and redirect installation * fix: mac macos * Remove installation .md and make it dropdown * Update installation of SDK * Grammar --------- Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com>
jmaslek
added a commit
that referenced
this pull request
Apr 13, 2023
…quirements and more (#4382) * fix: changed button styles * Make Rosetta requirements more clear * Update installation instructions * Add seperation * Update windows.md * Update installation docs * fix country choices (#4403) * Hotfix/plotsbackend start (#4404) * readd removed plots_backend().start() from merged PR * Update backend.py --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Update helper_classes.py (#4378) Co-authored-by: James Maslek <jmaslek11@gmail.com> * Add improvements to the website * Fix keys wrong redirect * Update installation * Update requirements * move things around * Restructure everything * Details * fix: mac issue and redirect installation * fix: mac macos * Remove installation .md and make it dropdown * Update installation of SDK * Grammar --------- Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com> Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: Colin Delahunty <72827203+colin99d@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not tested this fix, but the current code crashes when I make an installer from the SDK.