Interactive tables using react #4386

jose-donato · 2023-03-02T18:41:52Z

demo

This PR adds the functionality to spin up a pywry window containing react (or any frontend library code).

sets foundation for adding more web components
adds interactive tables

todo:

add docs on how to change and how it is structured
move all formatting code inside print_rich_table
do the formatting inside (after sending the raw df to the pywry window)
style with our components

JerBouma · 2023-03-03T10:37:45Z

Would it be possible to include an export button? In which you can filter and then export that sub-selection?

jose-donato · 2023-03-03T12:19:37Z

Would it be possible to include an export button? In which you can filter and then export that sub-selection?

Yuuup for sure.

Keep those suggestions coming

JerBouma · 2023-03-03T12:52:07Z

Another must have in my opinion is being able to filter by dates. I think this change will actually allow the limit flag to be removed. Due to how easy it is to search, we don't need that flag anymore. For a lot of functionality the limit flag is just there to reduce clutter while with this table functionality it no longer is clutter since you can filter so well.

In my opinion just nice to have not necessarily must-have:

1. It would be nice if we can have clickable URLs as seen in the screenshot below. Here it is getting cut-off (and thus not usable). We got that complaint a couple of times, also happens in stocks/fa/mgmt.

2. What's powerful is that you can plot a series within this table. So for example if I obtain the income statement as you see here, if I could click a row and press plot that's powerful. Then you can see revenue growth over time with ease etcetera. Probably a lot more use cases outside of this one.

jose-donato · 2023-03-03T13:26:02Z

Another must have in my opinion is being able to filter by dates. I think this change will actually allow the limit flag to be removed. Due to how easy it is to search, we don't need that flag anymore. For a lot of functionality the limit flag is just there to reduce clutter while with this table functionality it no longer is clutter since you can filter so well.

In my opinion just nice to have not necessarily must-have:

1. It would be nice if we can have clickable URLs as seen in the screenshot below. Here it is getting cut-off (and thus not usable). We got that complaint a couple of times, also happens in stocks/fa/mgmt.

2. What's powerful is that you can plot a series within this table. So for example if I obtain the income statement as you see here, if I could click a row and press plot that's powerful. Then you can see revenue growth over time with ease etcetera. Probably a lot more use cases outside of this one.

yea we increase the limit to 500 for now 😃

is easy peasy
is very interesting. gonna try it

JerBouma · 2023-03-03T13:28:24Z

Do limit even higher if possible, some data series are based on dates that can go all the way back to e.g. 1980 and offer daily data. Unless this would slow everything down a lot of course!

jose-donato · 2023-03-03T13:30:10Z

Do limit even higher if possible, some data series are based on dates that can go all the way back to e.g. 1980 and offer daily data. Unless this would slow everything down a lot of course!

what limit number do you think is reasonable in the meantime?

it wouldn't be a problem because of pagination, and everything is virtualized (only rows present on the screen are rendered)

JerBouma · 2023-03-03T13:32:57Z

I'd say go with a thousand for now. Little bit worried we might cut-off some data in due time so there needs to be a more dynamic solution at some point in time (basically no limit).

jose-donato · 2023-03-03T13:34:06Z

I'd say go with a thousand for now. Little bit worried we might cut-off some data in due time so there needs to be a more dynamic solution at some point in time (basically no limit).

I like the no limit but have to talk with @jmaslek for the best way to do this without breaking anything

codecov · 2023-03-13T15:23:31Z

Codecov Report

❗ No coverage uploaded for pull request base (develop@723a395). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #4386   +/-   ##
==========================================
  Coverage           ?   54.42%           
==========================================
  Files              ?      596           
  Lines              ?    53657           
  Branches           ?        0           
==========================================
  Hits               ?    29202           
  Misses             ?    24455           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* feat: experimenting tables with react * feat: adding new interactive tables * feat: adding more table features * small changes * update * Update backend.py * Update backend.py * fix: dark mode? * feat: lot of table improvements * fix: my b * fix: load only when prod * feat: naive detect links and dates * handle index and column names * increased min width * codespell * mypy, pylint * fix: added new chart, export, etc * testing * updates * fix : add PLOT_OPEN_EXPORT, USE_INTERACTIVE_DF to user dataclass * bump pywry version, readd removed `plots_backend().start()` * req files * Update unit-test.yml * Update unit-test.yml * Update unit-test.yml * updates * fixing some date things * update table * fix formatting with timezones * fixing some long prints and tables * Mickey Mouse Co-authored-by: teh_coderer <tehcoderer@users.noreply.github.com> Co-authored-by: jose-donato <jose-donato@users.noreply.github.com> * fix: ?!?!? * adding limit arg to all print_rich_table * tests * lint * simple by Default on interactive charts * playing with some css (thks jose) * Fix #4426 * Edit some structure * fix sdk generation * Update backend.py * fa menu tested and working * fix #4460 * fix #4460 drop indices * update tests * update tests * Update helper_funcs.py * tests * Update unit-test.yml * Update etf.ipynb --------- Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com> Co-authored-by: teh_coderer <tehcoderer@users.noreply.github.com> Co-authored-by: jose-donato <jose-donato@users.noreply.github.com> Co-authored-by: James Maslek <jmaslek11@gmail.com>

jose-donato added 2 commits March 2, 2023 17:28

feat: experimenting tables with react

83a081a

feat: adding new interactive tables

5f88516

reviewpad bot added the feat XL Extra Large feature label Mar 2, 2023

feat: adding more table features

e496250

jose-donato requested a review from tehcoderer March 2, 2023 23:33

jose-donato and others added 5 commits March 2, 2023 23:35

small changes

25042dc

update

c0b3b83

Merge branch 'develop' into feature/tables

00bbeb2

Update backend.py

d543282

Update backend.py

f09ca95

fix: dark mode?

239d8d4

jose-donato and others added 11 commits March 3, 2023 13:49

feat: lot of table improvements

e7e41f5

fix: my b

defdc36

fix: load only when prod

7319181

feat: naive detect links and dates

ed20a07

handle index and column names

d64fcea

Merge branch 'develop' into feature/tables

48c8b02

increased min width

150a941

codespell

b604dea

mypy, pylint

141b9c6

fix: added new chart, export, etc

9091dba

fix: merge

9dd412c

andrewkenreich and others added 18 commits March 7, 2023 00:10

adding limit arg to all print_rich_table

46bf4c1

tests

0c95b2a

lint

268559c

simple by Default on interactive charts

6d77152

playing with some css (thks jose)

d757019

Fix #4426

fcd22a6

Edit some structure

20ca67c

Merge branch 'develop' into feature/tables

0d219fd

Merge branch 'develop' into feature/tables

b87b04e

fix sdk generation

610395b

Update backend.py

5580eda

fa menu tested and working

9dac87d

fix #4460

6d09c67

fix #4460 drop indices

91b782b

Merge branch 'OpenBBTerminal-main' into feature/tables

ea8b9f0

update tests

76fc1bd

update tests

ab814ee

Update helper_funcs.py

71fadf8

tehcoderer and others added 5 commits March 13, 2023 11:31

tests

4566397

Update unit-test.yml

97c3b84

Update etf.ipynb

81d2ec0

Merge branch 'develop' into feature/tables

db858a8

Merge branch 'develop' into feature/tables

70f768a

jmaslek approved these changes Mar 13, 2023

View reviewed changes

jmaslek added this pull request to the merge queue Mar 13, 2023

Merged via the queue into develop with commit 40cfe81 Mar 13, 2023

piiq deleted the feature/tables branch March 22, 2023 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interactive tables using react #4386

Interactive tables using react #4386

jose-donato commented Mar 2, 2023 •

edited

Loading

JerBouma commented Mar 3, 2023

jose-donato commented Mar 3, 2023

JerBouma commented Mar 3, 2023 •

edited

Loading

jose-donato commented Mar 3, 2023

JerBouma commented Mar 3, 2023

jose-donato commented Mar 3, 2023

JerBouma commented Mar 3, 2023

jose-donato commented Mar 3, 2023

codecov bot commented Mar 13, 2023 •

edited

Loading

Interactive tables using react #4386

Interactive tables using react #4386

Conversation

jose-donato commented Mar 2, 2023 • edited Loading

JerBouma commented Mar 3, 2023

jose-donato commented Mar 3, 2023

JerBouma commented Mar 3, 2023 • edited Loading

jose-donato commented Mar 3, 2023

JerBouma commented Mar 3, 2023

jose-donato commented Mar 3, 2023

JerBouma commented Mar 3, 2023

jose-donato commented Mar 3, 2023

codecov bot commented Mar 13, 2023 • edited Loading

Codecov Report

jose-donato commented Mar 2, 2023 •

edited

Loading

JerBouma commented Mar 3, 2023 •

edited

Loading

codecov bot commented Mar 13, 2023 •

edited

Loading