Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing guide (added a new feature while doing so) #4391

Merged
merged 27 commits into from
Mar 9, 2023
Merged

Update contributing guide (added a new feature while doing so) #4391

merged 27 commits into from
Mar 9, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Mar 3, 2023

I added a new function so that I could live through reading the documentation

@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@03c18f5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #4391   +/-   ##
==========================================
  Coverage           ?   54.71%           
==========================================
  Files              ?      596           
  Lines              ?    53630           
  Branches           ?        0           
==========================================
  Hits               ?    29342           
  Misses             ?    24288           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek
Copy link
Collaborator Author

jmaslek commented Mar 3, 2023

I also added codecov because it took 1 line.

hjoaquim
hjoaquim reviewed Mar 9, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@hjoaquim
Copy link
Contributor

hjoaquim commented Mar 9, 2023

@jmaslek did some additions here: 77ab0b2

Please let me know if you agree.

@jmaslek
Copy link
Collaborator Author

jmaslek commented Mar 9, 2023

@jmaslek did some additions here: 77ab0b2

Please let me know if you agree.

Yup all good! I took another quick pass at and made some small changes

hjoaquim
hjoaquim approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@hjoaquim hjoaquim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great IMO, I think this PR touched a lot of stuff, and our contributing guidelines are now completely up-to-date!

@jmaslek jmaslek added this pull request to the merge queue Mar 9, 2023
Merged via the queue into develop with commit 36c0c0f Mar 9, 2023
@jmaslek jmaslek deleted the feature/contributing-update branch March 9, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

Assignees
No one assigned
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaslek @hjoaquim