Make the UI a little cleaner #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoaquim
reviewed
Mar 6, 2023
| @@ -44,6 +44,10 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| no_ticker_message = ( | |||
There was a problem hiding this comment.
shouldn't the cmds under this menu also be grey if ticker is not loaded?
There was a problem hiding this comment.
So the reason they aren't is because they can all be run with cmd -t
| @@ -129,46 +129,48 @@ def print_help(self): | |||
| stock_str = f"{s_intraday} {self.ticker}" | |||
|
|
|||
| mt = MenuText("stocks/ta/", 90) | |||
| mt.add_param("_ticker", stock_str) | |||
| mt.add_param( | |||
There was a problem hiding this comment.
should we also have the load cmd here? the functionality is there tho
hjoaquim
approved these changes
Mar 6, 2023
jmaslek
added a commit
that referenced
this pull request
Apr 13, 2023
* Make the UI a little cleaner * ta load --------- Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4399