Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stocks/fa/enterprise, now stocks/fa/mktcap, functionality #4424

Merged
merged 10 commits into from
Mar 8, 2023

Conversation

JerBouma
Copy link
Contributor

@JerBouma JerBouma commented Mar 7, 2023

Description

Main issue was that the command was a bit strange to work with. It gave insights but only for a relative short period. This makes it so you get all the periods by default and includes a start and end date. Given that enterprise value shares a lot of similarities with that of stock prices, it made sense it followed a similar logic.

Mostly did this change since I am using it in the Academia presentations.

image

image

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Mar 7, 2023
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat S Small T-Shirt size Feature labels Mar 7, 2023
@deeleeramone
Copy link
Contributor

The value for market cap should not be limited to annual or quarterly, and there is a need for this number to be calculated on a daily level.

Screenshot 2023-03-08 at 9 48 52 AM

@JerBouma JerBouma added this pull request to the merge queue Mar 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2023
@JerBouma JerBouma added this pull request to the merge queue Mar 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2023
@jmaslek jmaslek added this pull request to the merge queue Mar 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Mar 8, 2023

I dont know why the merge queue is randomly failing the linting when it passes here.

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 8, 2023

I found it. Codespell updated 2 hours ago. Guess they changed their dictionaries

@jmaslek jmaslek added this pull request to the merge queue Mar 8, 2023
Merged via the queue into develop with commit 87cea82 Mar 8, 2023
@jmaslek jmaslek deleted the feature/enterprise-plot branch March 8, 2023 20:54
jmaslek added a commit that referenced this pull request Apr 13, 2023
…#4424)

* Improve enterprise, now mktcap, functionality

* Update the scripts to work better with SDK

* Update the tests'

* Update integration tests

* Change SDK

* Spellings

* one more spelling

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants