-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve stocks/fa/enterprise
, now stocks/fa/mktcap
, functionality
#4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
feat XL
Extra Large feature
and removed
feat S
Small T-Shirt size Feature
labels
Mar 7, 2023
jmaslek
reviewed
Mar 7, 2023
jmaslek
approved these changes
Mar 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2023
I dont know why the merge queue is randomly failing the linting when it passes here. |
I found it. Codespell updated 2 hours ago. Guess they changed their dictionaries |
jmaslek
added a commit
that referenced
this pull request
Apr 13, 2023
…#4424) * Improve enterprise, now mktcap, functionality * Update the scripts to work better with SDK * Update the tests' * Update integration tests * Change SDK * Spellings * one more spelling --------- Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main issue was that the command was a bit strange to work with. It gave insights but only for a relative short period. This makes it so you get all the periods by default and includes a start and end date. Given that enterprise value shares a lot of similarities with that of stock prices, it made sense it followed a similar logic.
Mostly did this change since I am using it in the Academia presentations.
How has this been tested?
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others