Update FinanceDatabase to v2.0.9 #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
feat XL
jmaslek
approved these changes
Mar 8, 2023
|
Need to rewrite a whole bunch of tests just because the file extension changed from |
plz just not infinite numbers of tests |
Test passed so just 800k lines. I don't even get why it updates so much lol. |
jmaslek
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Update to v2.0.9 * Fix tests just because it said pkl instead of bz2 * Fix unrelated pylint issue * Someone doesnt care about linting * Update more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small change, fixes #4422. Now loads different files, other than that nothing changes. Old files are still there so nothing breaks for earlier versions. Files are now CSV compressed with BZ2 instead of Pickle. I don't fully agree with the security risk (as it is just me maintaining, no PRs in the last 3 years and you would need to add malicious code to a CSV file) but this just gets rid of the risk altogether.