Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/Temp Plots Backend html files #4448

Merged

Conversation

tehcoderer
Copy link
Contributor

@tehcoderer tehcoderer commented Mar 10, 2023

Fix: Edge case of temp html files deleted when multiple terminals are open and one is closed

fixes #4443

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@6a26d4e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4448   +/-   ##
==========================================
  Coverage           ?   54.70%           
==========================================
  Files              ?      596           
  Lines              ?    53638           
  Branches           ?        0           
==========================================
  Hits               ?    29345           
  Misses             ?    24293           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@montezdesousa montezdesousa added this pull request to the merge queue Mar 10, 2023
Merged via the queue into OpenBB-finance:develop with commit 49b0140 Mar 10, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
…n and one is closed (#4448)

Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Plot with message No html content to show, please provide a html_path or a html_str key
2 participants