Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds eval, lags, corr and season commands to the econometrics menu #4462

Merged

Conversation

northern-64bit
Copy link
Contributor

@northern-64bit northern-64bit commented Mar 12, 2023

Description

Adds eval (from the economy menu), lag (a new command), corr and season (from the forecast menu) commands to the econometrics menu.

How has this been tested?

Running the commands and getting the same/expected results as run in the other menus.

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@northern-64bit northern-64bit requested a review from JerBouma March 12, 2023 01:00
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Mar 12, 2023
@northern-64bit northern-64bit requested a review from jmaslek March 16, 2023 20:43
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@1171b91). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4462   +/-   ##
==========================================
  Coverage           ?   56.00%           
==========================================
  Files              ?      591           
  Lines              ?    53849           
  Branches           ?        0           
==========================================
  Hits               ?    30156           
  Misses             ?    23693           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 17, 2023

After loading in a dataset, season has no autocomplete options (same with corr, lag, eval, etc.):

Screenshot 2023-03-17 at 9 07 11 AM

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 17, 2023

Unlabeled seasonality plot
Screenshot 2023-03-17 at 9 11 58 AM

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 17, 2023

lag does not create a new variable: it overwrtites the current one

Screenshot 2023-03-17 at 9 16 33 AM

@northern-64bit
Copy link
Contributor Author

@jmaslek All issues should now have been fixed, except for labels on the plot of the season command.

This hasn't been done since this is a general issue (which also impacts the season command of the forecast menu) with add_corr_plot of plotly_helper. I can't see a good solution for this due to each line is added as it's own scatter. Therefore I'll create a new issue for it.

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@jmaslek jmaslek enabled auto-merge March 27, 2023 22:27
@jmaslek jmaslek added this pull request to the merge queue Mar 27, 2023
Merged via the queue into OpenBB-finance:develop with commit 1fb918f Mar 27, 2023
jmaslek added a commit that referenced this pull request Apr 13, 2023
…4462)

* Adds eval, lags, corr and season commands

* Fix ruff

* Fix linting

* Improve linting

* Fix linting

* Fix command parser

* Fix linting + bugs

* Add integration tests

* Fixes

* Improve `season` plot title

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
@northern-64bit northern-64bit deleted the feature/improve-econometrics branch April 25, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants