Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication QA fixes #4472

Merged
merged 11 commits into from
Mar 14, 2023
Merged

Authentication QA fixes #4472

merged 11 commits into from
Mar 14, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Mar 13, 2023

Description

  • Fixes sync command showing True, False instead of ON/OFF
  • Fixes logout command request
  • Fixes list command choices
  • Fix account menu autocompletion
  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added bug Fix bug account Authentication features labels Mar 13, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 13, 2023
@montezdesousa montezdesousa marked this pull request as ready for review March 14, 2023 10:11
@montezdesousa montezdesousa requested a review from hjoaquim March 14, 2023 10:13
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@0a15ec9). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4472   +/-   ##
==========================================
  Coverage           ?   54.42%           
==========================================
  Files              ?      596           
  Lines              ?    53661           
  Branches           ?        0           
==========================================
  Hits               ?    29203           
  Misses             ?    24458           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue Mar 14, 2023
Merged via the queue into develop with commit 7ec63f8 Mar 14, 2023
@piiq piiq deleted the hotfix/fix_auth_qa branch March 22, 2023 14:03
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* fix logout cmd

* fix sync flag

* change msg

* update request test for delete session

* fix autocompletion for routines upload

* append to list of choices

* fix autocompletioin

* black

* mypy

* rewrite tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Authentication features bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants