Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix OPENBB_ for .env vars #4475

Merged
merged 9 commits into from
Mar 14, 2023
Merged

Prefix OPENBB_ for .env vars #4475

merged 9 commits into from
Mar 14, 2023

Conversation

montezdesousa
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the bug Fix bug label Mar 14, 2023
@montezdesousa montezdesousa requested a review from hjoaquim March 14, 2023 11:36
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 14, 2023
@montezdesousa montezdesousa marked this pull request as draft March 14, 2023 12:02
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Mar 14, 2023
@montezdesousa montezdesousa marked this pull request as ready for review March 14, 2023 12:17
hjoaquim
hjoaquim approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@0a15ec9). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #4475   +/-   ##
==========================================
  Coverage           ?   54.44%           
==========================================
  Files              ?      596           
  Lines              ?    53670           
  Branches           ?        0           
==========================================
  Hits               ?    29218           
  Misses             ?    24452           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@montezdesousa montezdesousa enabled auto-merge March 14, 2023 13:38
@montezdesousa montezdesousa added this pull request to the merge queue Mar 14, 2023
Merged via the queue into develop with commit 5a69fba Mar 14, 2023
hjoaquim
hjoaquim reviewed Mar 14, 2023
View reviewed changes
openbb_terminal/core/models/credentials_model.py
@@ -76,3 +76,14 @@ def __repr__(self) -> str:
dataclass_repr += f" {key}='{value}', \n"

return f"{self.__class__.__name__}(\n{dataclass_repr[:-2]}\n)"

@classmethod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@montezdesousa maybe (in the future) this could be something that lives in a BaseModel and is inherited for the CredentialsModel, PreferencesModel etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed!

jmaslek pushed a commit that referenced this pull request Apr 13, 2023
@montezdesousa @jmaslek
Prefix OPENBB_ for .env vars (#4475)
2a4ee69 
* prefix OPENBB_ for .env vars

* black

* remove prefix only for dataclass

* remove openbb_ from setters

* don't send pref if sync disabled

* fix last commit

* add fields methods to handlers
@piiq piiq deleted the hotfix/fix_keys_prefs branch April 24, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees
No one assigned
Labels
bug Fix bug feat S Small T-Shirt size Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montezdesousa @hjoaquim