Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New table design #4485

Merged
merged 57 commits into from
Mar 23, 2023
Merged

New table design #4485

merged 57 commits into from
Mar 23, 2023

Conversation

jose-donato
Copy link
Contributor

@jose-donato jose-donato commented Mar 14, 2023

TODO:

  • show toast when columns are hidden --- fixed

  • stocks/fa/income - improve formatting so doesnt catch these numbers --- fixed

  • index shouldn't have date filter --- fixed
    image

  • stocks/fa/income -l 30 too many columns shown by default --- fixed
    image

@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label Mar 14, 2023
@jose-donato jose-donato added the do not merge Label to prevent pull request merge label Mar 15, 2023
@andrewkenreich
Copy link
Contributor

image

On stocks/dps/pos and a few others we can only sort on the last 2 columns and index, first 4 dont let you

@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat L Large T-Shirt size Feature labels Mar 17, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Mar 20, 2023

Reminders for me to check:

  • urls
  • long entries (like fred -q {} )

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 22, 2023

For you @jose-donato chart height:
Screenshot 2023-03-22 at 4 19 48 PM

@deeleeramone
Copy link
Contributor

For you @jose-donato chart height: Screenshot 2023-03-22 at 4 19 48 PM

Can we do away with the watermark now?

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 22, 2023

Can we do away with the watermark now?

patience

@deeleeramone
Copy link
Contributor

deeleeramone commented Mar 22, 2023

This doesn't actually solve either problem. The solution is to be able to scroll to the right on the PyWry window.

Screenshot 2023-03-22 at 2 11 40 PM

Screenshot 2023-03-22 at 2 14 47 PM

Columns are missing, and it should not be considered "advanced" to see all the data in a table. The table needs to dynamically sized for the content and column headers should respect the boundaries of the column width.

Screenshot 2023-03-22 at 12 29 18 AM

Before: Screenshot 2023-03-22 at 12 22 57 AM

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 22, 2023

This doesn't actually solve either problem. The solution is to be able to scroll to the right on the PyWry window.

Screenshot 2023-03-22 at 2 11 40 PM

Screenshot 2023-03-22 at 2 14 47 PM

Columns are missing, and it should not be considered "advanced" to see all the data in a table. The table needs to dynamically sized for the content and column headers should respect the boundaries of the column width.
Screenshot 2023-03-22 at 12 29 18 AM
Before: Screenshot 2023-03-22 at 12 22 57 AM

This was the requirement and the design. Does solve the problem as asked.

@deeleeramone
Copy link
Contributor

Does solve the problem as asked.

Doesn't feel solved to me.

Screenshot 2023-03-22 at 2 23 10 PM

@JerBouma
Copy link
Contributor

I've come to whine 😛

Please remove colouring on all tables, this means nothing at all. Within multiple tables numbers are marked red just because they are negative with little explanation why. Furthermore, numbers like close prices being green is just odd, have you ever seen negative close prices? Or within economy/valuation you see a bunch of ratios all marked green as if they are "good". The value added to me is just slim.

image

Table seems to be cut off and requires resize to display everything, why is that?

image

Why are we depicting just 10 per page on default? This cuts off all financial statements and is just weird in general. It should just depict everything up to a certain level (e.g. 50) and then create pages. Did you ever saw a website depict only 25% of a financial statement? This also applies to fixedincome/icebofa --options which, if you don't see the pages actually cuts off all available options.

image

This still a grammar mistake and does not include the path so I can't know where it is exported to.

image

Clicking on links does nothing for me.

image

Table columns are not always resized properly.

image

The command stocks/fa/rating leaves a blank table.

image

The command etf/search leaves a blank table (where stocks/search works fine)

image

@jose-donato jose-donato added the do not merge Label to prevent pull request merge label Mar 23, 2023
@jmaslek jmaslek removed the do not merge Label to prevent pull request merge label Mar 23, 2023
@jmaslek jmaslek added this pull request to the merge queue Mar 23, 2023
Merged via the queue into develop with commit dbd466d Mar 23, 2023
jmaslek added a commit that referenced this pull request Apr 13, 2023
* fix: new table design

* fix: added trillions

* fixing some raw data

* fix: trying to fix global+resize

* feat: improving design

* fix: new styling and lot of reorganizing

* title fix

* feat: new html

* fix: bottom bar

* fix: table dates

* fix: table html

* fix: new filtering

* fix: new filtering

* fix: long

* Lint

* Lint again

* fix: beautiful james suggestions

* fix: some more fixes

* fix: typo

* fix economy bug

* feat: added toast to notify user and some more cleanup

* fix: more issues

* tests

* fix: james updates

* fix: added banner to charts as well

* fixing title

* better fix

* feat: added column resizing and any number of columns

* auto column width - poc

* feat: added colors toggle, support to display source, fixed some more issues

* fix: table deploy

* fix: table issue

* fix header

* fix: some fixes

* fix: remember pagination and default pagination to 30

* mypy

* Colins tests

* Fix economy test

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: teh_coderer <me@tehcoderer.com>
Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>
@piiq piiq deleted the feature/table_design branch April 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants