-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New table design #4485
New table design #4485
Conversation
…nce/OpenBBTerminal into feature/table_design
…amestonkTerminal into feature/table_design
Reminders for me to check:
|
…nce/OpenBBTerminal into feature/table_design
…nce/OpenBBTerminal into feature/table_design
For you @jose-donato chart height: |
Can we do away with the |
patience |
This doesn't actually solve either problem. The solution is to be able to scroll to the right on the PyWry window.
|
I've come to whine 😛 Please remove colouring on all tables, this means nothing at all. Within multiple tables numbers are marked red just because they are negative with little explanation why. Furthermore, numbers like close prices being green is just odd, have you ever seen negative close prices? Or within economy/valuation you see a bunch of ratios all marked green as if they are "good". The value added to me is just slim. Table seems to be cut off and requires resize to display everything, why is that? Why are we depicting just 10 per page on default? This cuts off all financial statements and is just weird in general. It should just depict everything up to a certain level (e.g. 50) and then create pages. Did you ever saw a website depict only 25% of a financial statement? This also applies to This still a grammar mistake and does not include the path so I can't know where it is exported to. Clicking on links does nothing for me. Table columns are not always resized properly. The command The command |
* fix: new table design * fix: added trillions * fixing some raw data * fix: trying to fix global+resize * feat: improving design * fix: new styling and lot of reorganizing * title fix * feat: new html * fix: bottom bar * fix: table dates * fix: table html * fix: new filtering * fix: new filtering * fix: long * Lint * Lint again * fix: beautiful james suggestions * fix: some more fixes * fix: typo * fix economy bug * feat: added toast to notify user and some more cleanup * fix: more issues * tests * fix: james updates * fix: added banner to charts as well * fixing title * better fix * feat: added column resizing and any number of columns * auto column width - poc * feat: added colors toggle, support to display source, fixed some more issues * fix: table deploy * fix: table issue * fix header * fix: some fixes * fix: remember pagination and default pagination to 30 * mypy * Colins tests * Fix economy test --------- Co-authored-by: James Maslek <jmaslek11@gmail.com> Co-authored-by: teh_coderer <me@tehcoderer.com> Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>
TODO:
show toast when columns are hidden --- fixed
stocks/fa/income
- improve formatting so doesnt catch these numbers --- fixedindex shouldn't have date filter --- fixed
stocks/fa/income -l 30
too many columns shown by default --- fixed