Adds BaseModel and SystemModel
#4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezdesousa
requested changes
Mar 15, 2023
There was a problem hiding this comment.
I think we might need to add this to CredentiasModel and PreferencesModel, for some reason it's not doing repr as in the parent. Maybe pydantic overrides this if not specified.
def __repr__(self) -> str:
return super().__repr__()You can test in a Jupyter notebook with CredentialsModel() for e.g.
…Terminal into feature/base-class
reviewpad
bot
added
feat M
montezdesousa
requested changes
Mar 21, 2023
Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com>
Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com>
…Terminal into feature/base-class
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4491 +/- ##
==========================================
Coverage ? 55.27%
==========================================
Files ? 588
Lines ? 53451
Branches ? 0
==========================================
Hits ? 29546
Misses ? 23905
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
montezdesousa
approved these changes
Mar 22, 2023
jmaslek
pushed a commit
that referenced
this pull request
Apr 13, 2023
* adding BaseModel * initial version of the system model * creating setup functions and removing constants from config_terminal * removing log_supress const * fix test * merge * system handler * fix import * centralized configs setup * repr to use the BaseModel * updating i18n dict location * ignoring warning on wrong type-var * ruff * Update openbb_terminal/core/models/system_model.py Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * Update openbb_terminal/core/models/system_model.py Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com> * import literal * loading env files before the plot backend is called * fix tests/openbb_terminal/test_terminal_helper.py * tests need to have i18n initialized * fix seeking_alpha tests --------- Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseModelAdds common functionality to our data classes by adding a parent class
BaseModel.Applied to:
SystemModelconfig_terminal.pyvariables into SystemModelosto SystemModel --> TBD in a different PR