Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made fa/pt more accurate #4503

Merged
merged 7 commits into from
Mar 17, 2023
Merged

Made fa/pt more accurate #4503

merged 7 commits into from
Mar 17, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Mar 16, 2023

Description

Adjusts the analysts predictions for stock splits.
It works with stock sources: YahooFinance, AlphaVantage, Polygon, and EODHD
FMP did not need fixing, unrelated. I noticed that FMP only generates a table (no chart), is this an issue?
Fixes #4186

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 16, 2023
@colin99d colin99d enabled auto-merge March 17, 2023 13:17
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat XS Extra small feature labels Mar 17, 2023
@colin99d colin99d added this pull request to the merge queue Mar 17, 2023
@colin99d colin99d merged commit 09f53dd into develop Mar 17, 2023
@colin99d colin99d deleted the hotfix/fapt branch March 17, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Stock splits are not correctly accounted for within stocks/fa/pt
2 participants