Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Loading Custom Files #4504

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Improve Loading Custom Files #4504

merged 3 commits into from
Mar 17, 2023

Conversation

colin99d
Copy link
Contributor

Description

Fixes: #4280

The error above will STILL happen because we still NEED to include a ticker symbol, but I did improve:

  • Allow --help to be used with load
  • Allow xlsx files to be used

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 16, 2023
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jmaslek jmaslek enabled auto-merge March 16, 2023 20:46
@jmaslek jmaslek added this pull request to the merge queue Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@18b82a7). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4504   +/-   ##
==========================================
  Coverage           ?   54.81%           
==========================================
  Files              ?      590           
  Lines              ?    53146           
  Branches           ?        0           
==========================================
  Hits               ?    29130           
  Misses             ?    24016           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 16, 2023
@colin99d colin99d added this pull request to the merge queue Mar 17, 2023
Merged via the queue into develop with commit 3aec94c Mar 17, 2023
@colin99d colin99d deleted the hotfix/4280 branch March 17, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Stocks/load --file doesn't work.
2 participants