Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling for dot in ticker #4513

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Improve handling for dot in ticker #4513

merged 1 commit into from
Mar 17, 2023

Conversation

colin99d
Copy link
Contributor

Description

Fixes #3127

Currently the equity report has an ugly exit if there is a "." in the ticker. I added a check in the controller to make the issue more clear.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Mar 17, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 17, 2023
@colin99d colin99d enabled auto-merge March 17, 2023 15:18
@colin99d colin99d added this pull request to the merge queue Mar 17, 2023
@colin99d colin99d merged commit 4ea20eb into develop Mar 17, 2023
@colin99d colin99d deleted the hotfix/3127 branch March 17, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /reports/ $ equity --symbol PETR3.SA
2 participants