Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Error Handling to the options class #4516

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Adds Error Handling to the options class #4516

merged 4 commits into from
Mar 17, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Mar 17, 2023

Description

Fixes #3454
Fixes #4515

This adds common sense error handling to the options class.

How has this been tested?

This is going to be VERY time specific, but if you run greeks on TSLA at expo 0 here is what you got before and after this PR:
Screenshot 2023-03-17 at 2 56 52 PM
Screenshot 2023-03-17 at 2 57 11 PM

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@84a3628). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 64c8172 differs from pull request most recent head 6a4fd70. Consider uploading reports for the commit 6a4fd70 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4516   +/-   ##
==========================================
  Coverage           ?   54.56%           
==========================================
  Files              ?      584           
  Lines              ?    52672           
  Branches           ?        0           
==========================================
  Hits               ?    28742           
  Misses             ?    23930           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@colin99d colin99d enabled auto-merge March 17, 2023 20:08
@colin99d colin99d added this pull request to the merge queue Mar 17, 2023
@colin99d colin99d merged commit 1dffba8 into develop Mar 17, 2023
@piiq piiq deleted the hotfix/3454 branch March 22, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
2 participants