Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --sheet-name to load on econometrics and forecast #4525

Merged
merged 14 commits into from
Apr 3, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Mar 18, 2023

Addresses/Fixes #4281

@jmaslek jmaslek added the enhancement Enhancement label Mar 18, 2023
@jmaslek jmaslek requested review from JerBouma and colin99d March 18, 2023 01:14
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 18, 2023
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@271fd49). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4525   +/-   ##
==========================================
  Coverage           ?   55.92%           
==========================================
  Files              ?      591           
  Lines              ?    53925           
  Branches           ?        0           
==========================================
  Hits               ?    30160           
  Misses             ?    23765           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JerBouma JerBouma added this pull request to the merge queue Apr 3, 2023
Merged via the queue into develop with commit f9e6b20 Apr 3, 2023
jmaslek added a commit that referenced this pull request Apr 13, 2023
* Add sheet-name to econometrics load

* Also do forecasting load

* Handle error when sheet not found
@piiq piiq deleted the feature/load-sheet branch April 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] --sheet-name doesn't exist on load
2 participants