Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show version flag not being saved in .env #4534

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Mar 20, 2023

Description

Forgot this one in the last feature flags controller changes

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the bug Fix bug label Mar 20, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 20, 2023
@montezdesousa montezdesousa requested a review from JerBouma March 20, 2023 11:08
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@1a1e8c0). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head c408973 differs from pull request most recent head 416d913. Consider uploading reports for the commit 416d913 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4534   +/-   ##
==========================================
  Coverage           ?   54.56%           
==========================================
  Files              ?      584           
  Lines              ?    52678           
  Branches           ?        0           
==========================================
  Hits               ?    28742           
  Misses             ?    23936           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@montezdesousa montezdesousa enabled auto-merge March 20, 2023 15:11
@jmaslek
Copy link
Collaborator

jmaslek commented Mar 21, 2023

I overwrote the timeout for the generate_sdk test. Seems like that actually does take longer than 30 seconds on the runner ¯_(ツ)_/¯

@montezdesousa montezdesousa added this pull request to the merge queue Mar 21, 2023
@montezdesousa montezdesousa merged commit d671884 into develop Mar 21, 2023
@jmaslek jmaslek deleted the hotfix/show_version branch March 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants