Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the Upcoming Command #4547

Merged
merged 9 commits into from
Mar 21, 2023
Merged

Fixes the Upcoming Command #4547

merged 9 commits into from
Mar 21, 2023

Conversation

colin99d
Copy link
Contributor

Description

  • Summary of the change / bug fix.

Fixes #4541

This PR switches to just hitting the Seeking Alpha API directly. This increases the speed and reliability of the command.Also, since we have access to the API, we could technically get any information shown below:
Screenshot 2023-03-21 at 9 54 32 AM

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Mar 21, 2023
@colin99d colin99d requested a review from jmaslek March 21, 2023 13:58
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceone

@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat S Small T-Shirt size Feature labels Mar 21, 2023
@colin99d colin99d added this pull request to the merge queue Mar 21, 2023
@colin99d colin99d merged commit 5425b06 into develop Mar 21, 2023
@piiq piiq deleted the hotfix/4541 branch March 22, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat L Large T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] stocks/disc/upcoming - no results being returned.
2 participants