Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/PyWry Linux Wheels-Import Error Handing #4561

Merged
merged 16 commits into from
Mar 23, 2023
Merged

hotfix/PyWry Linux Wheels-Import Error Handing #4561

merged 16 commits into from
Mar 23, 2023

Conversation

tehcoderer
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Mar 22, 2023
reviewpad[bot]
reviewpad bot suggested changes Mar 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

reviewpad[bot]
reviewpad bot suggested changes Mar 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

jose-donato
jose-donato reviewed Mar 22, 2023
View reviewed changes
openbb_terminal/core/plots/no_import.py
[yellow]Platform-specific notes[/]
Here is the underlying web engine each platform uses you might need to install.

[green]Linux[/]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

reviewpad[bot]
reviewpad bot suggested changes Mar 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

@codecov
Copy link

codecov bot commented Mar 22, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@18070bc). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #4561   +/-   ##
==========================================
  Coverage           ?   56.13%           
==========================================
  Files              ?      587           
  Lines              ?    53543           
  Branches           ?        0           
==========================================
  Hits               ?    30059           
  Misses             ?    23484           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

reviewpad[bot]
reviewpad bot suggested changes Mar 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

@andrewkenreich andrewkenreich added the do not merge Label to prevent pull request merge label Mar 22, 2023
@andrewkenreich andrewkenreich removed the do not merge Label to prevent pull request merge label Mar 23, 2023
reviewpad[bot]
reviewpad bot previously requested changes Mar 23, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

@jmaslek jmaslek enabled auto-merge March 23, 2023 19:58
@jmaslek jmaslek added this pull request to the merge queue Mar 23, 2023
Merged via the queue into OpenBB-finance:develop with commit 7972098 Mar 23, 2023
@tehcoderer tehcoderer deleted the hotfix/pywry-charts branch March 23, 2023 21:07
jmaslek added a commit that referenced this pull request Apr 13, 2023
@tehcoderer @andrewkenreich @jmaslek
hotfix/PyWry Linux Wheels-Import Error Handing (#4561)
03428b5 
* init

* Update openbb.dockerfile

* fixing linting

* req files CLI update

* bump pywry

* new width/weight env vars for pywry specifically

* Update backend.py

* req files

* Update backend.py

* last bump pywry 0.4.0

* Update dashboards_controller.py

---------

Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>
Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-donato jose-donato jose-donato left review comments

@jmaslek jmaslek jmaslek approved these changes

@reviewpad reviewpad[bot] reviewpad[bot] left review comments

Assignees
No one assigned
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehcoderer @jmaslek @jose-donato @andrewkenreich