Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added start_date functionality #4564

Merged
merged 8 commits into from
Mar 23, 2023
Merged

Added start_date functionality #4564

merged 8 commits into from
Mar 23, 2023

Conversation

colin99d
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 22, 2023
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@6969433). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4564   +/-   ##
==========================================
  Coverage           ?   56.18%           
==========================================
  Files              ?      586           
  Lines              ?    53491           
  Branches           ?        0           
==========================================
  Hits               ?    30053           
  Misses             ?    23438           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat S Small T-Shirt size Feature labels Mar 23, 2023
@jmaslek jmaslek enabled auto-merge March 23, 2023 18:21
@jmaslek jmaslek added this pull request to the merge queue Mar 23, 2023
Merged via the queue into develop with commit 18070bc Mar 23, 2023
jmaslek added a commit that referenced this pull request Apr 13, 2023
* Added start_date functionality

* Updated tests

* Added fixes

* Fix test

* retest

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
@piiq piiq deleted the hotfix/testing branch April 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants