Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings logger #4597

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Update settings logger #4597

merged 6 commits into from
Mar 27, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Mar 27, 2023

Description

  • Updates settings_logger.py to use dataclass models
  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the analytics Logging and analytics label Mar 27, 2023
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Mar 27, 2023
@montezdesousa montezdesousa marked this pull request as ready for review March 27, 2023 13:32
@montezdesousa montezdesousa requested a review from hjoaquim March 27, 2023 13:32
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@b6b42af). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 8ed907a differs from pull request most recent head 3b87f38. Consider uploading reports for the commit 3b87f38 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4597   +/-   ##
==========================================
  Coverage           ?   56.18%           
==========================================
  Files              ?      587           
  Lines              ?    53529           
  Branches           ?        0           
==========================================
  Hits               ?    30075           
  Misses             ?    23454           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@montezdesousa montezdesousa marked this pull request as draft March 27, 2023 13:59
@montezdesousa montezdesousa marked this pull request as ready for review March 27, 2023 17:59
@jmaslek jmaslek added this pull request to the merge queue Mar 27, 2023
Merged via the queue into develop with commit 1171b91 Mar 27, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* update settings loggers

* change to python version

* update sdk helper

* pylint
@piiq piiq deleted the feature/settings_logger branch April 24, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics Logging and analytics feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants