Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch tweetnews exceptions #4603

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Catch tweetnews exceptions #4603

merged 4 commits into from
Mar 28, 2023

Conversation

montezdesousa
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the bug Fix bug label Mar 28, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@73f6184). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4603   +/-   ##
==========================================
  Coverage           ?   55.99%           
==========================================
  Files              ?      591           
  Lines              ?    53860           
  Branches           ?        0           
==========================================
  Hits               ?    30157           
  Misses             ?    23703           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed resolve the issue of the terminal crashing upon enabling it.

Screenshot 2023-03-28 at 8 14 10 AM

Screenshot 2023-03-28 at 8 14 38 AM

@montezdesousa montezdesousa enabled auto-merge March 28, 2023 15:46
@montezdesousa montezdesousa added this pull request to the merge queue Mar 28, 2023
Merged via the queue into develop with commit b89fdfc Mar 28, 2023
@montezdesousa montezdesousa deleted the hotfix/tweetnews branch March 28, 2023 16:25
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* catch tweetnews exceptions

* catch all exceptions

* pylint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Settings/tbnews - Enabling the feature flag breaks the terminal. Crashes on restart.
2 participants