Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter icebofa file by title #4609

Merged
merged 7 commits into from
Apr 2, 2023
Merged

Filter icebofa file by title #4609

merged 7 commits into from
Apr 2, 2023

Conversation

elyanah-aco
Copy link
Contributor

@elyanah-aco elyanah-aco commented Mar 28, 2023

Description

Closes #4594 by filtering ICE BofA file by the selected series. Also fixes IndexErrors raised when no series match the provided parameters.

How has this been tested?

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 28, 2023
@elyanah-aco elyanah-aco marked this pull request as ready for review March 29, 2023 00:00
@jmaslek jmaslek requested a review from JerBouma March 29, 2023 13:18
@JerBouma
Copy link
Contributor

Thanks for the PR!

The functionality crashes unfortunately when you use --category duration given that it plots multiple lines. Could you look into that?

image

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@271fd49). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4609   +/-   ##
==========================================
  Coverage           ?   55.93%           
==========================================
  Files              ?      591           
  Lines              ?    53920           
  Branches           ?        0           
==========================================
  Hits               ?    30158           
  Misses             ?    23762           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@JerBouma JerBouma enabled auto-merge March 30, 2023 07:37
@JerBouma JerBouma added this pull request to the merge queue Apr 2, 2023
Merged via the queue into OpenBB-finance:develop with commit e78ec27 Apr 2, 2023
jmaslek added a commit that referenced this pull request Apr 13, 2023
* Add icebofa csv filtering by title

* Fix description display, rewrite code to avoid raising index error

* Reformat with black

* Replace if-else with ternary operator

* Fix issue when multiple indices are selected

---------

Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com>
Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] fixedincome/icebofa --description falsely prints all results instead of the one selected
3 participants