-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter icebofa file by title #4609
Filter icebofa file by title #4609
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4609 +/- ##
==========================================
Coverage ? 55.93%
==========================================
Files ? 591
Lines ? 53920
Branches ? 0
==========================================
Hits ? 30158
Misses ? 23762
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
* Add icebofa csv filtering by title * Fix description display, rewrite code to avoid raising index error * Reformat with black * Replace if-else with ternary operator * Fix issue when multiple indices are selected --------- Co-authored-by: Jeroen Bouma <jer.bouma@gmail.com> Co-authored-by: James Maslek <jmaslek11@gmail.com>
Description
Closes #4594 by filtering ICE BofA file by the selected series. Also fixes
IndexErrors
raised when no series match the provided parameters.How has this been tested?
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others