Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/disc upcoming #4643

Merged
merged 6 commits into from
Apr 1, 2023
Merged

Hotfix/disc upcoming #4643

merged 6 commits into from
Apr 1, 2023

Conversation

IgorWounds
Copy link
Contributor

Fixing according to the #4553 issue

@IgorWounds IgorWounds added the bug Fix bug label Mar 30, 2023
@IgorWounds IgorWounds requested a review from deeleeramone March 30, 2023 20:54
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 30, 2023
@IgorWounds IgorWounds marked this pull request as draft March 30, 2023 21:15
@deeleeramone
Copy link
Contributor

Dates, as an argument input, need to be able to accept a string:

Screenshot 2023-03-30 at 2 18 55 PM

@IgorWounds IgorWounds marked this pull request as ready for review March 30, 2023 21:33
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@f87154b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #4643   +/-   ##
==========================================
  Coverage           ?   55.93%           
==========================================
  Files              ?      591           
  Lines              ?    53919           
  Branches           ?        0           
==========================================
  Hits               ?    30157           
  Misses             ?    23762           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IgorWounds IgorWounds enabled auto-merge March 30, 2023 22:43
@IgorWounds IgorWounds disabled auto-merge March 31, 2023 08:57
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Mar 31, 2023
deeleeramone
deeleeramone approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@IgorWounds IgorWounds added this pull request to the merge queue Apr 1, 2023
Merged via the queue into develop with commit a0c0a99 Apr 1, 2023
@IgorWounds IgorWounds deleted the hotfix/disc-upcoming branch April 7, 2023 14:07
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
@IgorWounds @jmaslek
Hotfix/disc upcoming (#4643)
f602858 
* Fix start_date

* Fix start_date

* Fix linting

* Fix limit parameter, view and tests

* Remove page_num, adjust view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeleeramone deeleeramone deeleeramone approved these changes

Assignees
No one assigned
Labels
bug Fix bug feat S Small T-Shirt size Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorWounds @deeleeramone