Hotfix/4526

[colin99d]

Description

Fixes #4526

This hits the nasdaq API directly, instead of web scraping market watch. So this is better in every way.

How has this been tested?

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

• Make sure affected commands still run in terminal
• Ensure the SDK still works
• Check any related reports

Checklist:

• I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
• Update our documentation following these guidelines. Update any user guides that are affected by the changes.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding integration test script.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@9435fd7). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #4682   +/-   ##
==========================================
  Coverage           ?   57.51%           
==========================================
  Files              ?      588           
  Lines              ?    53792           
  Branches           ?        0           
==========================================
  Hits               ?    30941           
  Misses             ?    22851           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[deeleeramone]

2023 Apr 05, 13:06 (🦋) /stocks/fa/ $ sec --source FinancialModelingPrep

No filings found for ticker AAPL, consider increasing the value for --pages. Showing recent filings instead.

This source does not hit the correct endpoint for the function. The correct endpoint is here: https://site.financialmodelingprep.com/developer/docs/#Financial-Statements-List

The i18n file needs to be updated as well.

Prints SEC filings of the company. The following fields are expected: Filing Date, Document Date, Type, Category, Amended, and Link. [Source: Market Watch and FinancialModelingPrep]

[colin99d]

Im going to add the FMP endpoint, but it has some limitations, and it doesn't seem useful to me now that we are pulling directly from Nasdaq.

[colin99d]

Actually, per Jeroen it should just be deleted.

[deeleeramone]

@colin99d

(🦋) /stocks/fa/ $ sec

Year will be ignored if form_group is not specified
No data found for AAPL

[deeleeramone]

I suggest upping the default value for --limit to be 100 instead of 20, thereby ensuring all results from the year and form type are returned.

When an invalid form group is selected, the response is not uniform. quarter returns nothing, but a random string of characters returns the default output. Ideally, an error message is printed indicating that the choice is not valid, what the valid choices are, and what results are being returned instead of the error.

There are a few items that need to be updated still:

• The help dialogue in the controller needs to be updated still.

• The description of the attribute within the StocksFundamentalAnalysis class:

The docstrings are pointing at a file that shouldn't exist anymore because the sources have both been replaced by a new one.

One item which may fall out of scope for this PR, because it is also all items in the module, is that with the new tables, the view aspect of the SDK becomes relevant and a reason to include the _chart version of each function. _chart for all functions that returns a DataFrame can be a choice for using the interactive tables.

[jmaslek]

lgtm

[deeleeramone]

I have a question, why is there a new file called, "marketwatch_model.py", which only contains one function - which is sourced from Nasdaq? There is already market_watch_model, this seems oddly confusing.