Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with holder #4693

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Fix issue with holder #4693

merged 2 commits into from
Apr 10, 2023

Conversation

JerBouma
Copy link
Contributor

@JerBouma JerBouma commented Apr 5, 2023

This fixes #4691

image

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 5, 2023
@deeleeramone
Copy link
Contributor

shrs --holder major returns a duplicate of the index instead of the values.

Screenshot 2023-04-07 at 8 57 09 PM

@montezdesousa montezdesousa enabled auto-merge April 10, 2023 10:17
@montezdesousa montezdesousa added this pull request to the merge queue Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@e55bf3d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4693   +/-   ##
==========================================
  Coverage           ?   57.54%           
==========================================
  Files              ?      589           
  Lines              ?    53841           
  Branches           ?        0           
==========================================
  Hits               ?    30984           
  Misses             ?    22857           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Merged via the queue into develop with commit af1f448 Apr 10, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com>
@piiq piiq deleted the hotfix/shrs-holders branch April 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] stocks/fa/shrs requires --holder when using --export
3 participants